-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Implement bounding volumes for primitive shapes #11336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1725541
Add dim2 and dim3 folders for bounding volumes
Jondolf bc905c6
Implement `Bounded2d` for most 2D primitives and add some helpers
Jondolf 7260d53
Add `RegularPolygon::vertices` and impl `Bounded2d`
Jondolf a201086
Implement `Bounded3d` for 3D primitives and add some helpers
Jondolf 8330fc2
Mention vertex placement for `RegularPolygon::vertices`
Jondolf b4286e2
Remove redundant explicit doc link targets
Jondolf 659c7c7
Fix `from_point_cloud` docs
Jondolf 6b43180
Fix and simplify bounded impls for planes and lines
Jondolf 78e9adc
Add `Triangle2d::circumcircle`, use for bounded impls of triangle and…
Jondolf 3c70473
Add tests for `Bounded2d` impls
Jondolf dff24a3
Fix cone bounding sphere
Jondolf 57558f3
Add tests for `Bounded3d` impls
Jondolf 2ef9d6d
Handle obtuse and acute triangles differently
Jondolf e3de411
Clamp conical frustum bounding sphere when circumcenter is outside
Jondolf 6965bc0
Address review feedback
Jondolf ba006dc
Remove `rotate_vec2` in favor of `Mat2::from_angle(rot) * vec`
Jondolf aa5431d
Add `# Panics` docs and improve comment wording
Jondolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.