Skip to content

Add the annulus shape to the 2d_shapes example #12742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add the annulus shape to the 2d_shapes example #12742

merged 2 commits into from
Apr 2, 2024

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik commented Mar 27, 2024

Objective

Since adding the Annulus primitive shape (#12706, #12734), the 2d_shapes example has become outdated.

Solution

This PR adds the annulus shape to the 2d_shapes example:

image


Changelog

Added

  • Annulus shape to the 2d_shapes example

(as an added bonus, the example now features Newton's ROYGBIV rainbow palette ^^ no it doesn't, but one can shoehorn..)

@pablo-lua pablo-lua added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Blocked This cannot move forward until something else changes and removed S-Blocked This cannot move forward until something else changes labels Mar 27, 2024
@pablo-lua
Copy link
Contributor

Linked PR merged :)

@Chubercik Chubercik marked this pull request as ready for review April 1, 2024 22:25
@james7132 james7132 added this pull request to the merge queue Apr 2, 2024
Merged via the queue into bevyengine:main with commit 017ffc5 Apr 2, 2024
@Chubercik Chubercik deleted the 2d_shapes_example_annulus branch April 2, 2024 09:58
chompaa pushed a commit to chompaa/bevy that referenced this pull request Apr 5, 2024
# Objective

- Depends on bevyengine#12734.

Since adding the `Annulus` primitive shape (bevyengine#12706, bevyengine#12734), the
`2d_shapes` example has become outdated.

## Solution

This PR adds the annulus shape to the `2d_shapes` example:


![image](https://github.com/bevyengine/bevy/assets/37378746/e620362d-bec6-4660-bf6e-d70babff8179)

---

## Changelog

### Added

- `Annulus` shape to the `2d_shapes` example

(~~as an added bonus, the example now features Newton's
[ROYGBIV](https://en.wikipedia.org/wiki/ROYGBIV) rainbow palette ^^~~ no
it doesn't, but one can shoehorn..)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants