Remove manual apply_deferred in bevy_ui
#14768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
changed the title
bevy_uiapply_deferred in bevy_ui
JMS55
approved these changes
Aug 15, 2024
benfrankel
approved these changes
Aug 15, 2024
janhohenheim
approved these changes
Aug 15, 2024
janhohenheim
added
S-Ready-For-Final-Review
|
Yeah, exclusive world access is heavily conflicting lol. |
|
What happens if someone disables automatic |
|
That can only be done locally as far as I'm aware. If there's a global setting (now or later), it will break a great deal more than this (which didn't seem to have any effect anyways). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This
apply_deferreddoesn't seem to have any effect, pointlessly restricts parallelism and is responsible for a large number of system order ambiguities. Spotted as part of #7386.Solution
Remove it.
This is the only manual apply_deferred in the code base currently.
Testing
I've checked various UI examples and
split_screen, and couldn't discern any difference.This looks like a remnant of a
(a, apply_deferred, b).chain()pattern wherebgot removed, leaving us with a weird vestige.