Skip to content

Fixing text sizes for examples #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tjlaxs
Copy link
Contributor

@tjlaxs tjlaxs commented Sep 13, 2024

Objective

Solution

  • Go through Pixel Eagle examples (and examples all in all)
  • If default size is used it is usually left there
  • If size of font is touched try dividing with 1.2 and round it to nearest whole number

Testing

  • Run example before and after
  • Make sure examples text are readable or like before cosmic-text change

Showcase

Before:
image

After:
image

@ickshonpe ickshonpe added A-Text Rendering and layout for characters C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Sep 13, 2024
@alice-i-cecile alice-i-cecile added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Sep 14, 2024
@tjlaxs tjlaxs marked this pull request as ready for review September 14, 2024 17:19
@tjlaxs
Copy link
Contributor Author

tjlaxs commented Sep 14, 2024

Mostly tiny changes like that the text fits better in buttons, with some exceptions like transparency_ui. And then larger problems like the text_debug example. Tried to make everything at least usable.

@rparrett
Copy link
Contributor

Cross-referencing a list I made, could you double-check these?

borders
low_power
multiple_windows
render_ui_to_texture
stepping
text
ui
ui_scaling

@tjlaxs
Copy link
Contributor Author

tjlaxs commented Sep 15, 2024

Rechecking these:

  • borders
  • low_power
  • multiple_windows
  • render_ui_to_texture
  • stepping
  • text
  • ui
  • ui_scaling

And was so confused with the text_debug problems example that I had made all of the fonts the exact same size, might change these back to show better way of different font sizes in the case.

@tjlaxs
Copy link
Contributor Author

tjlaxs commented Sep 15, 2024

  • borders and low_power had been fixed/touched elsewhere and were already fine
  • multiple_windows and render_ui_to_texture looked fine, and there is the tiny font size change to Pixel Eagle images but nothing drastic and default size is used
  • Stepping isn't an example but is used in the breakout example but did fix the font size for it
  • Had forgotten text example some how, but will fix them text_debug changes
  • Examples ui and ui_scaling still need changes

Will do these changes now.

Sidenote... second time around, I seem to understand better what the examples are trying to show.

@tjlaxs
Copy link
Contributor Author

tjlaxs commented Sep 15, 2024

Now the text_debug font sizes don't match the Pixel Eagle images, but the size changes were newer than the cosmic-commit. So I guessed these were the correct ones.

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 16, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 16, 2024
Merged via the queue into bevyengine:main with commit 522d82b Sep 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Text Rendering and layout for characters C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various examples need their font sizes adjusted post-cosmic-text
4 participants