Move Name out of bevy_core
#16894
Merged
Move Name out of bevy_core
#16894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
D-Trivial
alice-i-cecile
added
X-Contentious
|
This will be one of the first "blessed" components, so it's not a fully uncontroversial decision. I think this is the right choice though, since my understanding is that this will be needed for the BSN macro. |
ItsDoot
approved these changes
Dec 19, 2024
| @@ -53,7 +53,7 @@ impl<T> Default for ReportHierarchyIssue<T> { | |||
| /// (See B0004 explanation linked in warning message) | |||
| pub fn check_hierarchy_component_has_valid_parent<T: Component>( | |||
| parent_query: Query< | |||
| (Entity, &Parent, Option<&bevy_core::Name>), | |||
There was a problem hiding this comment.
Not necessary for this PR, but we could replace the Option<&Name> + Entity with NameOrEntity
There was a problem hiding this comment.
Yeah I agree, I'll leave it off just to keep things less controversial, but it'd be a nice little follow-up.
Co-Authored-By: Christian Hughes <[email protected]>
lewiszlw
approved these changes
Dec 19, 2024
bushrat011899
added
S-Ready-For-Final-Review
alice-i-cecile
added
X-Blessed
ItsDoot
added
the
M-Needs-Migration-Guide
Merged
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Contributes to bevyengine#16892 ## Solution - Moved `Name` and `NameOrEntity` into `bevy_ecs::name`, and added them to the prelude. ## Testing - CI ## Migration Guide If you were importing `Name` or `NameOrEntity` from `bevy_core`, instead import from `bevy_ecs::name`. --------- Co-authored-by: Christian Hughes <[email protected]>
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - Contributes to bevyengine#16892 ## Solution - Moved `Name` and `NameOrEntity` into `bevy_ecs::name`, and added them to the prelude. ## Testing - CI ## Migration Guide If you were importing `Name` or `NameOrEntity` from `bevy_core`, instead import from `bevy_ecs::name`. --------- Co-authored-by: Christian Hughes <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
# Objective After #16894, this example started logging errors: ``` ERROR bevy_asset::server: Failed to load asset 'scenes/load_scene_example.scn.ron' with asset loader 'bevy_scene::scene_loader::SceneLoader': Could not parse RON: 10:33: Expected string ``` Fixes #17798, this is the only actionable/unreported issue in there as far as I can tell. ## Solution Update the serialized scene with the expected format for `Name` ## Testing `cargo run --example scene` ## Discussion This example breaks very often and we don't always catch it. It might be nice to have this scene either 1. produce visual output so that it can be checked 2. panic if the scene fails to load (check for LoadState::Failed) Either of those would make the failures visible in [the example report](https://thebevyflock.github.io/bevy-example-runner/). Not sure which method would best suit the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_core#16892Solution
NameandNameOrEntityintobevy_ecs::name, and added them to the prelude.Testing
Migration Guide
If you were importing
NameorNameOrEntityfrombevy_core, instead import frombevy_ecs::name.