Skip to content

Sweep old entities from 2D binned render phases #17903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Sweep old entities from 2D binned render phases #17903

merged 1 commit into from
Feb 17, 2025

Conversation

superdump
Copy link
Contributor

Objective

Solution

  • Schedule sweep_old_entities in QueueSweep like BinnedRenderPhasePlugin does, but for 2D where that plugin is not used.

Testing

Tested with the modified shader_defs example in #17885 .

tychedelia
tychedelia approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@IceSentry IceSentry added A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 17, 2025
@pcwalton
Copy link
Contributor

Sorry about that, thanks for the catch!

@superdump superdump added this pull request to the merge queue Feb 17, 2025
@superdump
Copy link
Contributor Author

Sorry about that, thanks for the catch!

Easily done. No worries.

Merged via the queue into bevyengine:main with commit 8e783d3 Feb 17, 2025
32 checks passed
@hukasu hukasu mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton pcwalton approved these changes

@IceSentry IceSentry IceSentry approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2d specialized material shader defs aren't updated
4 participants
@superdump @pcwalton @IceSentry @tychedelia