Upgrade to Glam 0.29.3 and Simplify Feature Gating #18638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `nostd-libm` to always allow `bevy_math`, `bevy_input`, and `bevy_transform` in `bevy`.
bushrat011899
added
C-Dependencies
alice-i-cecile
approved these changes
Mar 31, 2025
|
I think this is really essential to reducing the pain for crate authors. |
Jondolf
approved these changes
Mar 31, 2025
Jondolf
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Mar 31, 2025
- Fixes #18397 - Supersedes #18474 - Simplifies 0.16 migration - Upgrade to Glam 0.29.3, which has backported the `nostd-libm` feature. - Expose a similar feature in `bevy_math` and enable it in `bevy_internal`, allowing `bevy_math`, `bevy_input`, and `bevy_transform` to be unconditional dependencies again. - CI --- - This includes `libm` as a dependency, but this was already the case in the common scenario where `rand` or many other features were enabled. Considering `libm` is an official Rust crate, it's a very low-risk dependency to unconditionally include. - For users who do not want `libm` included, simply import Bevy's subcrates directly, since `bevy_math/nostd-libm` will not be enabled. - I know we are _very_ late in the RC cycle for 0.16, but this has a substantial impact on the usability of `bevy` that I consider worth including.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_inputis now optional, but there's no way to enable it #18397nostd-libmfeature #18474Solution
nostd-libmfeature.bevy_mathand enable it inbevy_internal, allowingbevy_math,bevy_input, andbevy_transformto be unconditional dependencies again.Testing
Notes
libmas a dependency, but this was already the case in the common scenario whererandor many other features were enabled. Consideringlibmis an official Rust crate, it's a very low-risk dependency to unconditionally include.libmincluded, simply import Bevy's subcrates directly, sincebevy_math/nostd-libmwill not be enabled.bevythat I consider worth including.