Revert "Allow partial support for bevy_log in no_std (#18782)"
#18816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The downside is that all third-party crates with |
ChristopherBiscardi
approved these changes
Apr 13, 2025
Yup this is the lesser evil in my book, especially given that |
mockersf
approved these changes
Apr 14, 2025
jf908
pushed a commit
to jf908/bevy
that referenced
this pull request
May 12, 2025
…18782)" (bevyengine#18816) This reverts commit ac52cca. Fixes bevyengine#18815 # Objective bevyengine#18782 resulted in using `log` macros instead of `tracing` macros (in the interest of providing no_std support, specifically no_atomic support). That tradeoff isn't worth it, especially given that tracing is likely to get no_atomic support. ## Solution Revert bevyengine#18782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ac52cca.
Fixes #18815
Objective
#18782 resulted in using
logmacros instead oftracingmacros (in the interest of providing no_std support, specifically no_atomic support). That tradeoff isn't worth it, especially given that tracing is likely to get no_atomic support.Solution
Revert #18782