Make the example android app explicitly handle some device config change events to avoid getting the activity destroyed

[RabadanDotDev]

Objective

Fixes #18316

Solution

Add android:configChanges="orientation|screenSize" to the AndroidManifest.xml as indicated in https://stackoverflow.com/a/3329486 to avoid the GameActivity from getting destroyed, making the app stuck/crash.

Testing

I checked the results in my phone and after adding the config change the issue went away. The change is relatively trivial, so there shouldn't be the need to make a lot more testing.

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[Henauxg]

Shouldn't we also add the screenLayout flag ? This seems to be advised by the android documentation:

Note: If your application targets Android 3.2 (API level 13) or higher, also declare the 
"screenLayout" and "screenSize" configurations, because screen layout and screen size can 
change when a device switches between portrait and landscape orientations.

[RabadanDotDev]

It looks like so. I'll add that now. I tried finding if it made a difference somewhere and seems that if you try using split-screen functionality without screenLayout it does trigger the destroy.

It is possible that more events of the list should be added just in case, or perhaps try to find a way for bevy to persist if the GameActivity is destroyed/recreated.

[RabadanDotDev]

Looks like in Godot the solution was to basically add most of the list. I have the feeling that the best thing to do would be to add all of them to the list and pass the "onConfigurationChanged" event from android to the user in some way.

[Henauxg]

I'm fine with adding the configurations listed by Godot, most of them seem sensible enough (display and keyboards events). For the localization/layout, I've seen posts mentioning that layoutDirection could change while swapping to the phone photo mode, we wouldn't want the app to shutdown in this case.

Maybe the only one that I'm not sure about is navigation, as it says that it should not happen, but I guess there's no cost involved in adding it in ? BTW, is there a typo in the android documentation for this one ? Should it be A change to the navigation type instead of TA change ?

[RabadanDotDev]

Ok perfect! I'll add that now.

I think navigation may happen if a user connects a game pad ("D-pad" as in the docs?) to the device while the app is running. Maybe it says that it doesn't normally happen, as in most apps people wouldn't use one, but for games it is kind of more possible.

And yeah, looks like there is a typo on there. Maybe an issue should be raised in their bug tracker.