-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Split Camera.hdr
out into a new component
#18873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
I'm very much in favor of this change, but: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the rename, now that it's a type and not a field, it could be something like HighDynamicRange
instead of Hdr
.
I'm not very aware about the "internal render targets only" details though, so maybe it needs an additional information in the name to carry that.
The |
I don't think A or C should happen in this PR. I'd prefer to keep this PR without too many behaviour changes. We can have a discussion about renaming it later. For B, I think the current docs already do that? |
I agree with the general direction of this PR. I haven't reviewed the changes yet though. |
from what i understand from being on the rendering channel for far too long is that each camera has a texture that they render to, and later it gets transferred to the swapchain texture, the camera's texture is Hdr but the swapchain's texture is not |
Objective
Camera
initializationSolution
Camera.hdr
into a markerHdr
componentTesting
bloom_3d
exampleShowcase