Skip to content

Make uuid version less strict #18919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make uuid version less strict #18919

wants to merge 1 commit into from

Conversation

metdxt
Copy link

@metdxt metdxt commented Apr 24, 2025

Objective

Solution

  • Changed all dependency versions of uuid from "1.13.1" to "1" to only care for major version.

Testing

I've compiled my project without any problem, but I'm not sure if there was any specific reason bevy depended on this specific version of uuid maybe there are some caveats I'm not aware off. Running cargo test in bevy repo crashes my PC by OOM, so I couldn't properly test the whole package.

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@rparrett
Copy link
Contributor

rparrett commented Apr 24, 2025

It doesn't seem like the problem you're solving exists on Bevy's main branch.

The linked issue shows errors from Bevy 0.15.3 where uuid was pinned to 1.12 (edba2c4).

The current dependency was updated in #17689, and it seems like we do need at least that version.

@metdxt
Copy link
Author

metdxt commented Apr 24, 2025

Hm, indeed. This issue doesn't occur in main branch, I didn't notice the version was different.

@metdxt metdxt closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on strict version uuid breaks compatibility with other crates
2 participants