core_widgets example slider fix
#19810
Merged
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lour of the thumb so that it keeps the active colour during drags even when the pointer is not hovering the slider.
ickshonpe
changed the title
core_widgets example slider fix
ickshonpe
added
C-Examples
viridia
approved these changes
Jun 25, 2025
|
Does not seem to conflict with #19792 🙂 |
alice-i-cecile
approved these changes
Jun 29, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When dragging the slider thumb the thumb is only highlighted while the pointer is hovering the widget. If the pointer moves off the widget during a drag the thumb reverts to its normal unhovered colour.
Solution
Query for
CoreSliderDragStatein the slider update systems and set the lighter color if the thumb is dragged or hovered.