Make UIPlugin work in a headless mode #3908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-UI
alice-i-cecile
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Thanks :) Ideally, we'd be able to keep this systems working without actually drawing them, using #3754. This would allow us to mock out different window sizes to test layout, send mouse clicks to different regions, verify z-ordering and so on.
The ability to do this is very useful, because then these tests can be run in CI without requiring graphics (either with a GPU or CPU-driven graphics).
For now though, at least this will prevent crashes when we need the non-layout functionality of bevy_ui (which appears to just be type registration).
|
Will be investigating further into this! This should have been a draft, rather than a PR ready for review, sorry. |
kirusfg
force-pushed
the
fix/uiplugin-headless
branch
from
383de2b to
9a7852d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make UIPlugin usable if rendering is disabled.
Fixes #3815
Solution
Introduced a check in UIPlugin whether rendering is enabled; if not, rendering-dependent systems and resources are not added.