Fix filter query derive when missing generic arguments #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Apr 19, 2022
|
I think if this is to be merged it should only be as a backport and not to |
|
@BoxyUwU sounds reasonable. Do we have a branch for the next point release? I can point the PR to it. |
|
No branch yet. We should chat with @cart and the rest of the team to decide whether it's worth preparing one. |
|
ptrification has landed so I think this PR is obsolete apologies if ive misunderstood :) |
|
Ok. But just poke me if you folks decide to make a 0.7.1 release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4533
Solution
The solution is to employ the hack with replacing the world lifetime with the fetch one only when the world lifetime exists.
This will become irrelevant with these changes: TheRawMeatball#40. But it might be a good candidate for the patch release.