Skip to content

Remove generic from UiRect #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove generic from UiRect #5526

wants to merge 1 commit into from

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Aug 1, 2022 •
edited
Loading

(This was first noticed by @KDecay; please include them as a coauthor).

Objective

  • This generic was always set to Val in engine and user code.
  • We already have a way to modify the units: the Val::enum.
  • Reduce incidental complexity and boilerplate in bevy_ui's code.

Changelog

  • Removed the generic type T from UiRect. This is now always set to the Val enum.

Migration Guide

  • UiRect no longer supports generic types. Use a Val instead.

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Aug 1, 2022
@mockersf
Copy link
Member

mockersf commented Aug 1, 2022

it seems @KDecay already has a PR for that: #5404

@alice-i-cecile
Copy link
Member Author

Ah, I forget to check 🤦🏽‍♀️

@alice-i-cecile alice-i-cecile deleted the ui-generics-yeet branch August 1, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alice-i-cecile @mockersf