-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Merged by Bors] - [Fixes #6030] Bevy scene optional serde #6076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…`'s ``serialize`` feature
The basic strategy LGTM here :) What do you need to do still (other than resolve merge conflicts)? |
I'm a little unsure, but I believe I should:
Am I on the right track? 😅 Edit: It seems like I'm missing something else, because it feels like the |
Yep, seems like a solid checklist.
You forgot to add the |
Aaah of course, thank you very much! 😄 |
I fixed most of the issue that occurred when running The checks here on GitHub also seem to check out. Is there anything else I should look at? :) |
I think we're good now :) Can you move this PR out of draft status? |
Yep! :) |
bors try |
(Talk to Cart about being added to the team on Github to get the basic tier of bors and issue labelling permissions :D) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'm happy with this now. I think it fills the role of "let users use bevy_scene with their own serialization libraries".
Thank you, Alice! 😄 But lastly, the I tried to run |
It's not your PRs fault: we have a duplicate dependency in tree that we need to clean up. I think it might be spurious for old PRs due to weird git branching. |
Okay! Just out of curiosity, do you know what weird git branching would be in this case? |
My suspicion is that older PRs are using a cached version of the dependencies for bevy_audio, generated during a time when our transitive dependencies broke due to semver gnarliness: diwic/alsa-rs#90. New PRs aren't getting this, but I think the dependencies check in CI isn't eagerly recomputing whatever cache it had, because the PRs themselves haven't done anything that should fix it (the offending release was yanked). So now that I think about it, not actually git's fault: just weird caching problems. |
That sounds similar to the issues that can occur in the hope that it is as easily resolved as well! 😅 |
bors r+ |
# Objective Fixes #6030, making ``serde`` optional. ## Solution This was solved by making a ``serialize`` feature that can activate ``serde``, which is now optional. When ``serialize`` is deactivated, the ``Plugin`` implementation for ``ScenePlugin`` does nothing. Co-authored-by: Linus Käll <[email protected]>
Build failed (retrying...): |
Canceled. |
Sorry @cart, I synchronized the wrong branch... |
bors r+ |
# Objective Fixes #6030, making ``serde`` optional. ## Solution This was solved by making a ``serialize`` feature that can activate ``serde``, which is now optional. When ``serialize`` is deactivated, the ``Plugin`` implementation for ``ScenePlugin`` does nothing. Co-authored-by: Linus Käll <[email protected]>
Pull request successfully merged into main. Build succeeded:
|
# Objective Fixes bevyengine#6030, making ``serde`` optional. ## Solution This was solved by making a ``serialize`` feature that can activate ``serde``, which is now optional. When ``serialize`` is deactivated, the ``Plugin`` implementation for ``ScenePlugin`` does nothing. Co-authored-by: Linus Käll <[email protected]>
# Objective Fixes bevyengine#6030, making ``serde`` optional. ## Solution This was solved by making a ``serialize`` feature that can activate ``serde``, which is now optional. When ``serialize`` is deactivated, the ``Plugin`` implementation for ``ScenePlugin`` does nothing. Co-authored-by: Linus Käll <[email protected]>
# Objective Fixes bevyengine#6030, making ``serde`` optional. ## Solution This was solved by making a ``serialize`` feature that can activate ``serde``, which is now optional. When ``serialize`` is deactivated, the ``Plugin`` implementation for ``ScenePlugin`` does nothing. Co-authored-by: Linus Käll <[email protected]>
Objective
Fixes #6030, making
serde
optional.Solution
This was solved by making a
serialize
feature that can activateserde
, which is now optional.When
serialize
is deactivated, thePlugin
implementation forScenePlugin
does nothing.