Skip to content

Add option to disable gizmo rendering for specific cameras #8952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/bevy_gizmos/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ use bevy_render::{
VertexFormat, VertexStepMode,
},
renderer::RenderDevice,
view::RenderLayers,
Extract, ExtractSchedule, Render, RenderApp, RenderSet,
};
use bevy_transform::components::{GlobalTransform, Transform};
Expand Down Expand Up @@ -159,6 +160,10 @@ pub struct GizmoConfig {
pub depth_bias: f32,
/// Configuration for the [`AabbGizmo`].
pub aabb: AabbGizmoConfig,
/// Describes which rendering layers gizmos will be rendered to.
///
/// Gizmos will only be rendered to cameras with intersecting layers.
pub render_layers: RenderLayers,
}

impl Default for GizmoConfig {
Expand All @@ -169,6 +174,7 @@ impl Default for GizmoConfig {
line_perspective: false,
depth_bias: 0.,
aabb: Default::default(),
render_layers: Default::default(),
}
}
}
Expand Down
19 changes: 14 additions & 5 deletions crates/bevy_gizmos/src/pipeline_2d.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{
line_gizmo_vertex_buffer_layouts, DrawLineGizmo, LineGizmo, LineGizmoUniformBindgroupLayout,
SetLineGizmoBindGroup, LINE_SHADER_HANDLE,
line_gizmo_vertex_buffer_layouts, DrawLineGizmo, GizmoConfig, LineGizmo,
LineGizmoUniformBindgroupLayout, SetLineGizmoBindGroup, LINE_SHADER_HANDLE,
};
use bevy_app::{App, Plugin};
use bevy_asset::Handle;
Expand All @@ -17,7 +17,7 @@ use bevy_render::{
render_phase::{AddRenderCommand, DrawFunctions, RenderPhase, SetItemPipeline},
render_resource::*,
texture::BevyDefault,
view::{ExtractedView, Msaa, ViewTarget},
view::{ExtractedView, Msaa, RenderLayers, ViewTarget},
Render, RenderApp, RenderSet,
};
use bevy_sprite::{Mesh2dPipeline, Mesh2dPipelineKey, SetMesh2dViewBindGroup};
Expand Down Expand Up @@ -131,13 +131,22 @@ fn queue_line_gizmos_2d(
mut pipelines: ResMut<SpecializedRenderPipelines<LineGizmoPipeline>>,
pipeline_cache: Res<PipelineCache>,
msaa: Res<Msaa>,
config: Res<GizmoConfig>,
line_gizmos: Query<(Entity, &Handle<LineGizmo>)>,
line_gizmo_assets: Res<RenderAssets<LineGizmo>>,
mut views: Query<(&ExtractedView, &mut RenderPhase<Transparent2d>)>,
mut views: Query<(
&ExtractedView,
&mut RenderPhase<Transparent2d>,
Option<&RenderLayers>,
)>,
) {
let draw_function = draw_functions.read().get_id::<DrawLineGizmo2d>().unwrap();

for (view, mut transparent_phase) in &mut views {
for (view, mut transparent_phase, render_layers) in &mut views {
let render_layers = render_layers.copied().unwrap_or_default();
if !config.render_layers.intersects(&render_layers) {
continue;
}
let mesh_key = Mesh2dPipelineKey::from_msaa_samples(msaa.samples())
| Mesh2dPipelineKey::from_hdr(view.hdr);

Expand Down
15 changes: 12 additions & 3 deletions crates/bevy_gizmos/src/pipeline_3d.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use bevy_render::{
render_phase::{AddRenderCommand, DrawFunctions, RenderPhase, SetItemPipeline},
render_resource::*,
texture::BevyDefault,
view::{ExtractedView, Msaa, ViewTarget},
view::{ExtractedView, Msaa, RenderLayers, ViewTarget},
Render, RenderApp, RenderSet,
};

Expand Down Expand Up @@ -159,11 +159,20 @@ fn queue_line_gizmos_3d(
config: Res<GizmoConfig>,
line_gizmos: Query<(Entity, &Handle<LineGizmo>)>,
line_gizmo_assets: Res<RenderAssets<LineGizmo>>,
mut views: Query<(&ExtractedView, &mut RenderPhase<Transparent3d>)>,
mut views: Query<(
&ExtractedView,
&mut RenderPhase<Transparent3d>,
Option<&RenderLayers>,
)>,
) {
let draw_function = draw_functions.read().get_id::<DrawLineGizmo3d>().unwrap();

for (view, mut transparent_phase) in &mut views {
for (view, mut transparent_phase, render_layers) in &mut views {
let render_layers = render_layers.copied().unwrap_or_default();
if !config.render_layers.intersects(&render_layers) {
continue;
}

let mesh_key = MeshPipelineKey::from_msaa_samples(msaa.samples())
| MeshPipelineKey::from_hdr(view.hdr);

Expand Down
8 changes: 7 additions & 1 deletion crates/bevy_render/src/camera/camera.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use crate::{
prelude::Image,
render_asset::RenderAssets,
render_resource::TextureView,
view::{ColorGrading, ExtractedView, ExtractedWindows, VisibleEntities},
view::{ColorGrading, ExtractedView, ExtractedWindows, RenderLayers, VisibleEntities},
Extract,
};
use bevy_asset::{AssetEvent, Assets, Handle};
Expand Down Expand Up @@ -615,6 +615,7 @@ pub fn extract_cameras(
&VisibleEntities,
Option<&ColorGrading>,
Option<&TemporalJitter>,
Option<&RenderLayers>,
)>,
>,
primary_window: Extract<Query<Entity, With<PrimaryWindow>>>,
Expand All @@ -628,6 +629,7 @@ pub fn extract_cameras(
visible_entities,
color_grading,
temporal_jitter,
render_layers,
) in query.iter()
{
let color_grading = *color_grading.unwrap_or(&ColorGrading::default());
Expand Down Expand Up @@ -679,6 +681,10 @@ pub fn extract_cameras(
if let Some(temporal_jitter) = temporal_jitter {
commands.insert(temporal_jitter.clone());
}

if let Some(render_layers) = render_layers {
commands.insert(*render_layers);
}
}
}
}
Expand Down