-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-19601] Introduce options for adding certificates to trust without root #5609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-19601] Introduce options for adding certificates to trust without root #5609
Conversation
…omTrustStore Co-authored-by: tangowithfoxtrot <[email protected]>
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5609 +/- ##
==========================================
+ Coverage 45.12% 45.20% +0.07%
==========================================
Files 1565 1568 +3
Lines 71719 71839 +120
Branches 6424 6435 +11
==========================================
+ Hits 32363 32473 +110
- Misses 37979 37987 +8
- Partials 1377 1379 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1b7ed4c
to
a94e704
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19601
https://bitwarden.atlassian.net/browse/PM-19599
📔 Objective
All for customizing trusted root certificates without the need of
update-ca-certificates
. This helps in us not needing root in containers. This sets up the usage of the custom server certificate validation callback for SMTP and allHttpClient
s when created withIHttpClientFactory
. I am not callingAddX509ChainCustomization
in any project yet so this feature doesn't light up yet. But the expectation is that it would be added to all self hosted containers.This code is to replace this bash in the container start.
The default of the setting maps directly to the location we used to copy certificates from so for the most part 0 customization should have to be done by anyone to get this feature if there were previously placing certificates in that directory. The setting is largely exposed for developers to map it to a custom directory.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes