-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-18955] Improve performance of Billing invocations on Collections page #5618
base: main
Are you sure you want to change the base?
Conversation
…ization metadata endpoint
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
+ Coverage 45.12% 45.72% +0.59%
==========================================
Files 1565 1600 +35
Lines 71728 72609 +881
Branches 6424 6505 +81
==========================================
+ Hits 32368 33198 +830
- Misses 37983 37992 +9
- Partials 1377 1419 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Core/Billing/Services/Implementations/OrganizationBillingService.cs
Outdated
Show resolved
Hide resolved
src/Core/Billing/Services/Implementations/OrganizationBillingService.cs
Outdated
Show resolved
Hide resolved
src/Core/Billing/Services/Implementations/OrganizationBillingService.cs
Outdated
Show resolved
Hide resolved
…& make private method synchronous
…& make private method synchronous
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - thanks for making those changes. However, just as a heads up for future PR's, the reviewer is the one who should mark conversations as resolved.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18955
📔 Objective
customer.invoice_settings
object. This allows us to avoid retrieving the payment method entirely in the front-end.Tested with
📸 Screenshots
Screen.Recording.2025-04-07.at.16.41.13.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes