perf: Remove two trpc.viewer.public.event calls & use EventTypeRepository in RSCs
#20536
+107
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dosubot
bot
added
booking-page
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/04/25)1 reviewer was added to this PR based on Keith Williams's automation. |
…t-to-eventType-router
dosubot
bot
added
the
performance
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
Apr 5, 2025
| event: { | ||
| data?: Pick<BookerEvent, "length" | "bookingFields" | "price" | "currency" | "metadata"> | null; | ||
| }; | ||
| eventData: Pick<RouterOutputs["viewer"]["eventTypes"]["get"], "price" | "currency" | "length" | "metadata">; |
There was a problem hiding this comment.
bookingFields isn't needed
hbjORbj
commented
Apr 5, 2025
packages/features/embed/Embed.tsx
Outdated
| @@ -367,7 +366,7 @@ const EmailEmbed = ({ | |||
| locale={i18n.language} | |||
| browsingDate={month ? dayjs(month) : undefined} | |||
| selected={dayjs(selectedDate)} | |||
| weekStart={weekdayToWeekIndex(event?.data?.subsetOfUsers?.[0]?.weekStart)} | |||
| weekStart={weekdayToWeekIndex(eventTypeData?.users?.[0]?.weekStart)} | |||
There was a problem hiding this comment.
double check on this
hbjORbj
changed the title
hbjORbj
commented
Apr 5, 2025
| import { useBookerTime } from "../hooks/useBookerTime"; | ||
|
|
||
| const BookEventFormWrapper = ({ children, onCancel }: { onCancel: () => void; children: ReactNode }) => { | ||
| const { data } = useEvent(); |
There was a problem hiding this comment.
Removing trpc.viewer.public.event call
| @@ -271,7 +271,6 @@ const EmailEmbed = ({ | |||
| ], | |||
| shallow | |||
| ); | |||
| const event = useEvent(); | |||
There was a problem hiding this comment.
Removing trpc.viewer.public.event call
hbjORbj
changed the title
trpc.viewer.public.event calls & use EventTypeRepository in RSCs
…t-to-eventType-router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trpc.viewer.public.eventcalls by refactoring to use already server-fetched dataMandatory Tasks (DO NOT REMOVE)
How should this be tested?