Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove two trpc.viewer.public.event calls & use EventTypeRepository in RSCs #20536

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ac68838
refactor [user]/[type] server logic
hbjORbj Apr 2, 2025
b32a680
refactor useSlot
hbjORbj Apr 2, 2025
71939a6
refactor
hbjORbj Apr 2, 2025
9cec7ea
fix
hbjORbj Apr 2, 2025
b6cf29b
fix OG images
hbjORbj Apr 2, 2025
8396418
fix
hbjORbj Apr 3, 2025
5365d9d
remove event repository
hbjORbj Apr 4, 2025
851eaa1
remove publicViewer router event
hbjORbj Apr 4, 2025
7fd35a7
add getPublicEvent to eventTypes router
hbjORbj Apr 4, 2025
f396b32
Merge remote-tracking branch 'origin/main' into perf/move-public-even…
hbjORbj Apr 4, 2025
b5c2010
fix type checks
hbjORbj Apr 4, 2025
938fdb7
fix
hbjORbj Apr 4, 2025
c53a93a
fix
hbjORbj Apr 4, 2025
acbe1f5
Merge branch 'main' into perf/move-public-event-to-eventType-router
hbjORbj Apr 4, 2025
9bf3106
fix
hbjORbj Apr 4, 2025
cc279b3
refactor
hbjORbj Apr 4, 2025
2669bb1
fix
hbjORbj Apr 4, 2025
2199919
Merge remote-tracking branch 'origin/main' into perf/move-public-even…
hbjORbj Apr 4, 2025
0421aed
fix
hbjORbj Apr 4, 2025
8f844bb
fix
hbjORbj Apr 4, 2025
c10f7c5
Merge branch 'main' into perf/move-public-event-to-eventType-router
hbjORbj Apr 4, 2025
99eb053
Merge branch 'main' into perf/move-public-event-to-eventType-router
hbjORbj Apr 4, 2025
0990134
Merge remote-tracking branch 'origin/main' into perf/move-public-even…
hbjORbj Apr 5, 2025
620c90f
wip
hbjORbj Apr 5, 2025
38726d0
remove
hbjORbj Apr 5, 2025
905f6dc
fix types
hbjORbj Apr 5, 2025
05f07e9
restore
hbjORbj Apr 5, 2025
ae08f17
revert
hbjORbj Apr 5, 2025
bcd5171
revert
hbjORbj Apr 5, 2025
16c31ff
fix
hbjORbj Apr 5, 2025
629ba64
fix
hbjORbj Apr 5, 2025
307eb9e
fix
hbjORbj Apr 5, 2025
53d7a11
fix
hbjORbj Apr 5, 2025
1f482db
fix
hbjORbj Apr 5, 2025
fff5daa
fix
hbjORbj Apr 5, 2025
6390f1a
fix type check
hbjORbj Apr 6, 2025
ccbe18f
Merge remote-tracking branch 'origin/main' into perf/move-public-even…
hbjORbj Apr 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions apps/web/lib/d/[link]/[slug]/getServerSideProps.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import type { EmbedProps } from "app/WithEmbedSSR";
import { createRouterCaller } from "app/_trpc/context";
import type { GetServerSidePropsContext } from "next";
import { z } from "zod";

import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
import { getBookingForReschedule, getMultipleDurationValue } from "@calcom/features/bookings/lib/get-booking";
import type { GetBookingType } from "@calcom/features/bookings/lib/get-booking";
import { orgDomainConfig } from "@calcom/features/ee/organizations/lib/orgDomains";
import { EventTypeRepository } from "@calcom/lib/server/repository/eventType";
import { UserRepository } from "@calcom/lib/server/repository/user";
import slugify from "@calcom/lib/slugify";
import prisma from "@calcom/prisma";
import { RedirectType } from "@calcom/prisma/enums";
import { publicViewerRouter } from "@calcom/trpc/server/routers/publicViewer/_router";

import { getTemporaryOrgRedirect } from "@lib/getTemporaryOrgRedirect";
import type { inferSSRProps } from "@lib/types/inferSSRProps";
Expand All @@ -20,6 +19,11 @@ export type PageProps = inferSSRProps<typeof getServerSideProps> & EmbedProps;

async function getUserPageProps(context: GetServerSidePropsContext) {
const session = await getServerSession({ req: context.req });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
const sessionUserId = session.user.id;

const { link, slug } = paramsSchema.parse(context.params);
const { rescheduleUid, duration: queryDuration } = context.query;
const { currentOrgDomain, isValidOrgDomain } = orgDomainConfig(context.req);
Expand Down Expand Up @@ -107,22 +111,23 @@ async function getUserPageProps(context: GetServerSidePropsContext) {

let booking: GetBookingType | null = null;
if (rescheduleUid) {
booking = await getBookingForReschedule(`${rescheduleUid}`, session?.user?.id);
booking = await getBookingForReschedule(`${rescheduleUid}`, sessionUserId);
}

const isTeamEvent = !!hashedLink.eventType?.team?.id;

// We use this to both prefetch the query on the server,
// as well as to check if the event exist, so we c an show a 404 otherwise.
const caller = await createRouterCaller(publicViewerRouter);

const eventData = await caller.event({
username: name,
eventSlug: slug,
isTeamEvent,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
});
const eventData = await EventTypeRepository.getPublicEvent(
{
username: name,
eventSlug: slug,
isTeamEvent,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
},
sessionUserId
);

if (!eventData) {
return notFound;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
import { createRouterCaller } from "app/_trpc/context";
import type { GetServerSidePropsContext } from "next";
import { z } from "zod";

import { getServerSession } from "@calcom/features/auth/lib/getServerSession";
import { getMultipleDurationValue } from "@calcom/features/bookings/lib/get-booking";
import { getSlugOrRequestedSlug } from "@calcom/features/ee/organizations/lib/orgDomains";
import { orgDomainConfig } from "@calcom/features/ee/organizations/lib/orgDomains";
import { EventTypeRepository } from "@calcom/lib/server/repository/eventType";
import slugify from "@calcom/lib/slugify";
import prisma from "@calcom/prisma";
import { publicViewerRouter } from "@calcom/trpc/server/routers/publicViewer/_router";

const paramsSchema = z.object({
type: z.string().transform((s) => slugify(s)),
slug: z.string().transform((s) => slugify(s)),
});

export const getServerSideProps = async (context: GetServerSidePropsContext) => {
const session = await getServerSession({ req: context.req });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
const sessionUserId = session.user.id;
const { slug: teamSlug, type: meetingSlug } = paramsSchema.parse(context.params);
const { duration: queryDuration } = context.query;

Expand All @@ -39,16 +44,16 @@ export const getServerSideProps = async (context: GetServerSidePropsContext) =>

const org = isValidOrgDomain ? currentOrgDomain : null;

const caller = await createRouterCaller(publicViewerRouter);

const eventData = await caller.event({
username: teamSlug,
eventSlug: meetingSlug,
isTeamEvent: true,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
});

const eventData = await EventTypeRepository.getPublicEvent(
{
username: teamSlug,
eventSlug: meetingSlug,
isTeamEvent: true,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
},
sessionUserId
);
if (!eventData || !org) {
return {
notFound: true,
Expand Down
19 changes: 14 additions & 5 deletions apps/web/server/lib/[user]/[type]/getServerSideProps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type { GetBookingType } from "@calcom/features/bookings/lib/get-booking";
import { orgDomainConfig } from "@calcom/features/ee/organizations/lib/orgDomains";
import type { getPublicEvent } from "@calcom/features/eventtypes/lib/getPublicEvent";
import { getUsernameList } from "@calcom/lib/defaultEvents";
import { EventRepository } from "@calcom/lib/server/repository/event";
import { EventTypeRepository } from "@calcom/lib/server/repository/eventType";
import { UserRepository } from "@calcom/lib/server/repository/user";
import slugify from "@calcom/lib/slugify";
import prisma from "@calcom/prisma";
Expand Down Expand Up @@ -93,6 +93,10 @@ async function processSeatedEvent({

async function getDynamicGroupPageProps(context: GetServerSidePropsContext) {
const session = await getServerSession({ req: context.req });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
const sessionUserId = session.user.id;
const { user: usernames, type: slug } = paramsSchema.parse(context.params);
const { rescheduleUid, bookingUid } = context.query;

Expand Down Expand Up @@ -127,14 +131,14 @@ async function getDynamicGroupPageProps(context: GetServerSidePropsContext) {
// We use this to both prefetch the query on the server,
// as well as to check if the event exist, so we c an show a 404 otherwise.

const eventData = await EventRepository.getPublicEvent(
const eventData = await EventTypeRepository.getPublicEvent(
{
username: usernames.join("+"),
eventSlug: slug,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
},
session?.user?.id
sessionUserId
);

if (!eventData) {
Expand Down Expand Up @@ -177,6 +181,11 @@ async function getDynamicGroupPageProps(context: GetServerSidePropsContext) {

async function getUserPageProps(context: GetServerSidePropsContext) {
const session = await getServerSession({ req: context.req });
if (!session?.user?.id) {
return { redirect: { permanent: false, destination: "/auth/login" } };
}
const sessionUserId = session.user.id;

const { user: usernames, type: slug } = paramsSchema.parse(context.params);
const username = usernames[0];
const { rescheduleUid, bookingUid } = context.query;
Expand Down Expand Up @@ -210,14 +219,14 @@ async function getUserPageProps(context: GetServerSidePropsContext) {
const org = isValidOrgDomain ? currentOrgDomain : null;
// We use this to both prefetch the query on the server,
// as well as to check if the event exist, so we can show a 404 otherwise.
const eventData = await EventRepository.getPublicEvent(
const eventData = await EventTypeRepository.getPublicEvent(
{
username,
eventSlug: slug,
org,
fromRedirectOfNonOrgLink: context.query.orgRedirection === "true",
},
session?.user?.id
sessionUserId
);

if (!eventData) {
Expand Down
3 changes: 2 additions & 1 deletion packages/features/bookings/Booker/Booker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,8 @@ const BookerComponent = ({

<BookFormAsModal
onCancel={() => setSelectedTimeslot(null)}
visible={bookerState === "booking" && shouldShowFormInDialog}>
visible={bookerState === "booking" && shouldShowFormInDialog}
eventDuration={event?.data?.length}>
{EventBooker}
</BookFormAsModal>
<Toaster position="bottom-right" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { useCallback, useMemo, useRef } from "react";

import dayjs from "@calcom/dayjs";
import { AvailableTimes, AvailableTimesSkeleton } from "@calcom/features/bookings";
import type { IUseBookingLoadingStates } from "@calcom/features/bookings/Booker/components/hooks/useBookings";
import type { BookerEvent } from "@calcom/features/bookings/types";
import { AvailableTimes, AvailableTimesSkeleton } from "@calcom/features/bookings/components/AvailableTimes";
import type { SlotItemProps } from "@calcom/features/bookings/components/AvailableTimes";
import { useNonEmptyScheduleDays } from "@calcom/features/schedules";
import type { Slot } from "@calcom/features/schedules";
import { useSlotsForAvailableDates } from "@calcom/features/schedules/lib/use-schedule/useSlotsForDate";
Expand All @@ -23,9 +23,7 @@ type AvailableTimeSlotsProps = {
isLoading: boolean;
seatsPerTimeSlot?: number | null;
showAvailableSeatsCount?: boolean | null;
event: {
data?: Pick<BookerEvent, "length" | "bookingFields" | "price" | "currency" | "metadata"> | null;
};
event: SlotItemProps["event"];
customClassNames?: {
availableTimeSlotsContainer?: string;
availableTimeSlotsTitle?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,18 @@ import { DialogContent } from "@calcom/ui/components/dialog";
import { getDurationFormatted } from "../../../components/event-meta/Duration";
import { useBookerStore } from "../../store";
import { FromTime } from "../../utils/dates";
import { useEvent } from "../../utils/event";
import { useBookerTime } from "../hooks/useBookerTime";

const BookEventFormWrapper = ({ children, onCancel }: { onCancel: () => void; children: ReactNode }) => {
const { data } = useEvent();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing trpc.viewer.public.event call


return <BookEventFormWrapperComponent child={children} eventLength={data?.length} onCancel={onCancel} />;
const BookEventFormWrapper = ({
children,
onCancel,
eventDuration,
}: {
onCancel: () => void;
children: ReactNode;
eventDuration?: number;
}) => {
return <BookEventFormWrapperComponent child={children} eventDuration={eventDuration} onCancel={onCancel} />;
};

const PlatformBookEventFormWrapper = ({
Expand All @@ -31,17 +36,21 @@ const PlatformBookEventFormWrapper = ({
const { data } = useEventTypeById(eventId);

return (
<BookEventFormWrapperComponent child={children} eventLength={data?.lengthInMinutes} onCancel={onCancel} />
<BookEventFormWrapperComponent
child={children}
eventDuration={data?.lengthInMinutes}
onCancel={onCancel}
/>
);
};

export const BookEventFormWrapperComponent = ({
child,
eventLength,
eventDuration,
}: {
onCancel: () => void;
child: ReactNode;
eventLength?: number;
eventDuration?: number;
}) => {
const { i18n, t } = useLocale();
const selectedTimeslot = useBookerStore((state) => state.selectedTimeslot);
Expand All @@ -62,9 +71,9 @@ export const BookEventFormWrapperComponent = ({
language={i18n.language}
/>
</Badge>
{(selectedDuration || eventLength) && (
{(selectedDuration || eventDuration) && (
<Badge variant="grayWithoutHover" startIcon="clock" size="lg">
<span>{getDurationFormatted(selectedDuration || eventLength, t)}</span>
<span>{getDurationFormatted(selectedDuration || eventDuration, t)}</span>
</Badge>
)}
</div>
Expand All @@ -77,10 +86,12 @@ export const BookFormAsModal = ({
visible,
onCancel,
children,
eventDuration,
}: {
visible: boolean;
onCancel: () => void;
children: ReactNode;
eventDuration?: number;
}) => {
const isPlatform = useIsPlatform();

Expand All @@ -91,7 +102,9 @@ export const BookFormAsModal = ({
enableOverflow
className="[&_.modalsticky]:border-t-subtle [&_.modalsticky]:bg-default max-h-[80vh] pb-0 [&_.modalsticky]:sticky [&_.modalsticky]:bottom-0 [&_.modalsticky]:left-0 [&_.modalsticky]:right-0 [&_.modalsticky]:-mx-8 [&_.modalsticky]:border-t [&_.modalsticky]:px-8 [&_.modalsticky]:py-4">
{!isPlatform ? (
<BookEventFormWrapper onCancel={onCancel}>{children}</BookEventFormWrapper>
<BookEventFormWrapper eventDuration={eventDuration} onCancel={onCancel}>
{children}
</BookEventFormWrapper>
) : (
<PlatformBookEventFormWrapper onCancel={onCancel}>{children}</PlatformBookEventFormWrapper>
)}
Expand Down
4 changes: 2 additions & 2 deletions packages/features/bookings/components/AvailableTimes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ export type AvailableTimesProps = {
unavailableTimeSlots?: string[];
} & Omit<SlotItemProps, "slot">;

type SlotItemProps = {
export type SlotItemProps = {
slot: Slot;
seatsPerTimeSlot?: number | null;
selectedSlots?: string[];
onTimeSelect?: TOnTimeSelect;
onTentativeTimeSelect?: TOnTentativeTimeSelect;
showAvailableSeatsCount?: boolean | null;
event: {
data?: Pick<BookerEvent, "length" | "bookingFields" | "price" | "currency" | "metadata"> | null;
data?: Pick<BookerEvent, "length" | "price" | "currency" | "metadata"> | null;
};
customClassNames?: string;
confirmStepClassNames?: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function SearchBarComponent({ className }: SearchBarProps, ref: Ref<HTMLInputEle
return (
<Input
ref={ref}
className={classNames("max-w-48" ,className)}
className={classNames("max-w-48", className)}
placeholder={t("search")}
value={localValue}
onChange={handleSearchChange}
Expand Down
Loading
Loading