Skip to content

fix: precompiled resource bundle warnings #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: precompiled resource bundle warnings #1566

wants to merge 5 commits into from
+129 −4

Conversation

sebastianv1
Copy link

For SPM modules that use precompiled resource bundles (i.e .bundle files), Bazel throws the warning

WARNING: input 'Sources/Down/Resources/DownView (macOS).bundle' is a directory; dependency checking of directories is unsound

Instead of just referencing the .bundle path directly we should wrap it in a apple_bundle_import for the prebuilt bundle and then add it into the resources attr.

@sebastianv1
Copy link
Author

Resolves #1010 as well

@cgrindel cgrindel enabled auto-merge (squash) April 11, 2025 12:08
@cgrindel cgrindel changed the title Fix precompiled resource bundle warnings fix: precompiled resource bundle warnings Apr 11, 2025
@cgrindel cgrindel disabled auto-merge April 11, 2025 12:09
@cgrindel cgrindel enabled auto-merge (squash) April 11, 2025 12:09
auto-merge was automatically disabled April 11, 2025 14:23

Head branch was pushed to by a user without write access

@sebastianv1 sebastianv1 force-pushed the sebastianv1/fix-resource-warnings branch from 193497d to 4e01cab Compare April 11, 2025 14:23
@jpsim jpsim enabled auto-merge (squash) April 11, 2025 20:38
jpsim
jpsim approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgrindel
Copy link
Owner

@sebastianv1 It looks like one of the examples is failing with this PR. The tidy_and_test_matrix can be fixed by running bazel run //:tidy and checking in the updated files.

@sebastianv1
Copy link
Author

@cgrindel Hmm i ran bazel run //:tidy and there aren't any changes locally for me?

And I ran //examples:firebase_example_test_bazel_.bazelversion off main and that seems to fail as well for me; looks like we need to bump rules_xcodeproj. I can do that to unblock this PR as well everywhere.

auto-merge was automatically disabled April 15, 2025 15:14

Head branch was pushed to by a user without write access

@sebastianv1 sebastianv1 force-pushed the sebastianv1/fix-resource-warnings branch from 4e01cab to 9f94389 Compare April 15, 2025 15:14
@cgrindel
Copy link
Owner

@cgrindel Hmm i ran bazel run //:tidy and there aren't any changes locally for me?

And I ran //examples:firebase_example_test_bazel_.bazelversion off main and that seems to fail as well for me; looks like we need to bump rules_xcodeproj. I can do that to unblock this PR as well everywhere.

I am doing that in #1568. It should merge in a few minutes.

@cgrindel
Copy link
Owner

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = all_ci_tests
        • check-skipped = all_ci_tests
        • check-success = all_ci_tests
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = conventional_commit_check
        • check-neutral = conventional_commit_check
        • check-skipped = conventional_commit_check
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@cgrindel
Copy link
Owner

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 21, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = all_ci_tests
        • check-skipped = all_ci_tests
        • check-success = all_ci_tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = conventional_commit_check
        • check-skipped = conventional_commit_check
        • check-success = conventional_commit_check
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sebastianv1 @cgrindel
Fix precompiled resource bundle warnings
03b60e8 
For SPM modules that use precompiled resource bundles (i.e `.bundle` files), Bazel throws the warning
```
WARNING: input 'Sources/Down/Resources/DownView (macOS).bundle' is a directory; dependency checking of directories is unsound
```

Instead of just referencing the `.bundle` path directly we should wrap it in a `apple_bundle_import` for the prebuilt bundle and then add it into the `resources` attr.
@cgrindel cgrindel force-pushed the sebastianv1/fix-resource-warnings branch from 62729d6 to 03b60e8 Compare April 27, 2025 20:32
@cgrindel
Copy link
Owner

cgrindel commented May 3, 2025

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 3, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = all_ci_tests
        • check-skipped = all_ci_tests
        • check-success = all_ci_tests
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = conventional_commit_check
        • check-neutral = conventional_commit_check
        • check-skipped = conventional_commit_check
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@cgrindel
Copy link
Owner

cgrindel commented May 4, 2025

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 4, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -conflict [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = all_ci_tests
        • check-skipped = all_ci_tests
        • check-success = all_ci_tests
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = conventional_commit_check
        • check-neutral = conventional_commit_check
        • check-skipped = conventional_commit_check
  • -closed [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrindel cgrindel cgrindel approved these changes

@jpsim jpsim jpsim approved these changes

@brentleyjones brentleyjones Awaiting requested review from brentleyjones brentleyjones is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianv1 @cgrindel @jpsim