Add missing JS scope facets

[AndreasArvidsson]

No description provided.

[pokey]

In this code:

class Aaa {
  bbb() {
    ccc;
  }
  ddd() {}
}

Will "every funk name cap" still return bbb and ddd?

[AndreasArvidsson]

In this code:

class Aaa {
  bbb() {
    ccc;
  }
  ddd() {}
}

Will "every funk name cap" still return bbb and ddd?

No... I'm wondering if namedFunction.iteration.block and functionName.iteration.block really are facets we want? Shouldn't it just be namedFunction.iteration.class?

[pokey]

Yeah maybe we remove those? Where are they used? I mean I can see the use case in certain scenarios but it's a bummer to lose every funk within a method

[AndreasArvidsson]

This is the only instance before this pull request: https://github.com/cursorless-dev/cursorless/blob/49cc8cdb89ce19450f3cd41015f4a8fd91ebc623/data/fixtures/scopes/scss/namedFunction.iteration.block.scope

I definitely agree that every funk should work in a method. The question is just what to do with the facets. Should iteration.block be kept for css sake? We already have method.iteration.class so I don't think we need to add any new ones.

[AndreasArvidsson]

@pokey Ready for another view. I haven't renamed any of the facets. Besides that I'm feel this one is done now.