Skip to content

Add missing JS scope facets #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add missing JS scope facets #2890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ebfcd26
resource is not applicabler
AndreasArvidsson Apr 16, 2025
c772363
More migrations
AndreasArvidsson Apr 16, 2025
eb4f4fe
Merge branch 'main' into jsScopes
AndreasArvidsson Apr 16, 2025
dcaafe9
Update typescript fixtures
AndreasArvidsson Apr 16, 2025
feeb89a
Remove block iteration scope for classing
AndreasArvidsson Apr 16, 2025
61e0a83
Added not applicable to typescript
AndreasArvidsson Apr 16, 2025
d37b906
Added missing unsupported for typescripts
AndreasArvidsson Apr 16, 2025
caff249
Class type
AndreasArvidsson Apr 20, 2025
f132dd3
type field iteration
AndreasArvidsson Apr 20, 2025
f0c3aab
Type arguments
AndreasArvidsson Apr 20, 2025
ebc58a6
cast match
AndreasArvidsson Apr 20, 2025
e104f8e
Merge branch 'main' into jsScopes
AndreasArvidsson Apr 20, 2025
ada6a75
Remove block
AndreasArvidsson Apr 21, 2025
583b6f9
Merge branch 'main' into jsScopes
AndreasArvidsson Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/branch.loop.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
for (let i = 0; i < size; ++i) { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:34
>----------------------------------<
0| for (let i = 0; i < size; ++i) { }

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/branch.loop2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
for (const v of values) { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:27
>---------------------------<
0| for (const v of values) { }

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/branch.loop3.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
while(true) { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:15
>---------------<
0| while(true) { }

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/branch.loop4.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
do { } while(true);
---

[Content] =
[Removal] =
[Domain] = 0:0-0:19
>-------------------<
0| do { } while(true);

[Insertion delimiter] = "\n"
8 changes: 8 additions & 0 deletions data/fixtures/scopes/javascript.core/class.iteration.document.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

class MyClass { }
---

[Range] =
[Domain] = 1:0-1:17
>-----------------<
1| class MyClass { }
13 changes: 4 additions & 9 deletions data/fixtures/scopes/javascript.core/class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
class MyClass {

}
class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-2:1
>---------------
0| class MyClass {
1|
2| }
-<
[Domain] = 0:0-0:17
>-----------------<
0| class MyClass { }

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export default class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:32
>--------------------------------<
0| export default class MyClass { }

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/class3.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:24
>------------------------<
0| export class MyClass { }

[Insertion delimiter] = "\n\n"
8 changes: 8 additions & 0 deletions data/fixtures/scopes/javascript.core/className.iteration.document.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

class MyClass { }
---

[Range] =
[Domain] = 1:0-1:17
>-----------------<
1| class MyClass { }
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/collectionItem.unenclosed.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
let foo, bar;
---

[Range] = 0:4-0:12
>--------<
0| let foo, bar;

[Domain] = 0:0-0:13
>-------------<
0| let foo, bar;
13 changes: 11 additions & 2 deletions data/fixtures/scopes/javascript.core/functionName.method.iteration.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,19 @@ class MyClass {
}
---

[Range] =
[Domain] = 0:0-2:1
[#1 Range] =
[#1 Domain] = 0:0-2:1
>---------------
0| class MyClass {
1| myFunk() { }
2| }
-<


[#2 Range] =
[#2 Domain] = 0:15-2:0
>
0| class MyClass {
1| myFunk() { }
2| }
<
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/name.argument.formal.constructor.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MyClass {


[#3 Range] =
[#3 Domain] = 1:13-1:23
>----------<
[#3 Domain] = 1:14-1:22
>--------<
1| constructor(aaa, bbb) { }


Expand Down
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/name.argument.formal.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ function myFunk(aaa, bbb) { }


[#2 Range] =
[#2 Domain] = 0:15-0:25
>----------<
[#2 Domain] = 0:16-0:24
>--------<
0| function myFunk(aaa, bbb) { }


Expand Down
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/name.argument.formal.method.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MyClass {


[#3 Range] =
[#3 Domain] = 1:8-1:18
>----------<
[#3 Domain] = 1:9-1:17
>--------<
1| myFunk(aaa, bbb) { }


Expand Down
33 changes: 33 additions & 0 deletions data/fixtures/scopes/javascript.core/name.iteration.block.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
class MyClass {
myFunk() { }
}
---

[#1 Range] =
[#1 Domain] = 0:0-2:1
>---------------
0| class MyClass {
1| myFunk() { }
2| }
-<


[#2 Range] =
[#2 Domain] = 0:15-2:0
>
0| class MyClass {
1| myFunk() { }
2| }
<


[#3 Range] =
[#3 Domain] = 1:11-1:11
><
1| myFunk() { }


[#4 Range] =
[#4 Domain] = 1:14-1:15
>-<
1| myFunk() { }
19 changes: 19 additions & 0 deletions data/fixtures/scopes/javascript.core/name.iteration.block2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
function myFunk() { }
---

[#1 Range] =
[#1 Domain] = 0:0-0:21
>---------------------<
0| function myFunk() { }


[#2 Range] =
[#2 Domain] = 0:16-0:16
><
0| function myFunk() { }


[#3 Range] =
[#3 Domain] = 0:19-0:20
>-<
0| function myFunk() { }
13 changes: 13 additions & 0 deletions data/fixtures/scopes/javascript.core/name.iteration.block4.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
while (true) { }
---

[#1 Range] =
[#1 Domain] = 0:0-0:16
>----------------<
0| while (true) { }


[#2 Range] =
[#2 Domain] = 0:14-0:15
>-<
0| while (true) { }
13 changes: 11 additions & 2 deletions data/fixtures/scopes/javascript.core/namedFunction.method.iteration.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,19 @@ class MyClass {
}
---

[Range] =
[Domain] = 0:0-2:1
[#1 Range] =
[#1 Domain] = 0:0-2:1
>---------------
0| class MyClass {
1| myFunk() { }
2| }
-<


[#2 Range] =
[#2 Domain] = 0:15-2:0
>
0| class MyClass {
1| myFunk() { }
2| }
<
10 changes: 10 additions & 0 deletions data/fixtures/scopes/javascript.core/type.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:17
>-----------------<
0| class MyClass { }

[Insertion delimiter] = " "
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/value.argument.formal.constructor.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MyClass {


[#3 Range] =
[#3 Domain] = 1:13-1:31
>------------------<
[#3 Domain] = 1:14-1:30
>----------------<
1| constructor(aaa = 0, bbb = 1) { }


Expand Down
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/value.argument.formal.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ function myFunk(aaa = 0, bbb = 1) { }


[#2 Range] =
[#2 Domain] = 0:15-0:33
>------------------<
[#2 Domain] = 0:16-0:32
>----------------<
0| function myFunk(aaa = 0, bbb = 1) { }


Expand Down
4 changes: 2 additions & 2 deletions data/fixtures/scopes/javascript.core/value.argument.formal.method.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MyClass {


[#3 Range] =
[#3 Domain] = 1:8-1:26
>------------------<
[#3 Domain] = 1:9-1:25
>----------------<
1| myFunk(aaa = 0, bbb = 1) { }


Expand Down
10 changes: 10 additions & 0 deletions data/fixtures/scopes/typescript.core/class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
abstract class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:26
>--------------------------<
0| abstract class MyClass { }

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/typescript.core/class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export default abstract class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:41
>-----------------------------------------<
0| export default abstract class MyClass { }

[Insertion delimiter] = "\n\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/typescript.core/class3.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export abstract class MyClass { }
---

[Content] =
[Removal] =
[Domain] = 0:0-0:33
>---------------------------------<
0| export abstract class MyClass { }

[Insertion delimiter] = "\n\n"
4 changes: 2 additions & 2 deletions data/fixtures/scopes/typescript.core/type.argument.formal.constructor.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MyClass {


[#3 Range] =
[#3 Domain] = 1:13-1:28
>---------------<
[#3 Domain] = 1:14-1:27
>-------------<
1| constructor(value: number) { }


Expand Down
22 changes: 17 additions & 5 deletions data/fixtures/scopes/typescript.core/type.argument.formal.constructor.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,32 @@ class MyClass {
}
---

[Content] = 1:21-1:27
[#1 Content] =
[#1 Removal] =
[#1 Domain] = 0:0-2:1
>---------------
0| class MyClass {
1| constructor(value: number) { }
2| }
-<

[#1 Insertion delimiter] = " "


[#2 Content] = 1:21-1:27
>------<
1| constructor(value: number) { }

[Removal] = 1:19-1:27
[#2 Removal] = 1:19-1:27
>--------<
1| constructor(value: number) { }

[Leading delimiter] = 1:19-1:21
[#2 Leading delimiter] = 1:19-1:21
>--<
1| constructor(value: number) { }

[Domain] = 1:14-1:27
[#2 Domain] = 1:14-1:27
>-------------<
1| constructor(value: number) { }

[Insertion delimiter] = " "
[#2 Insertion delimiter] = " "
4 changes: 2 additions & 2 deletions data/fixtures/scopes/typescript.core/type.argument.formal.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ function myFunk(value: number) { }


[#2 Range] =
[#2 Domain] = 0:15-0:30
>---------------<
[#2 Domain] = 0:16-0:29
>-------------<
0| function myFunk(value: number) { }


Expand Down
Loading
Loading