#3180. Simplify JSAnyOperation tests. #3223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa1
approved these changes
Jun 13, 2025
|
@srujzs, do you have any final comments? |
srujzs
reviewed
Jun 13, 2025
Utils/expect_common.dart
Outdated
| @@ -401,7 +401,10 @@ final bool assertStatementsEnabled = (() { | |||
| })(); | |||
|
|
|||
| /// Is true iff js compiler is used | |||
| final bool isJS = identical(1.0, 1); | |||
| const bool isJS = identical(1.0, 1); | |||
There was a problem hiding this comment.
nit: For a general purpose check, check these. I believe the common advice is to check the specific semantic differences you care about for a test, but for a general purpose check, this is likely cleaner.
const bool isDDC = const bool.fromEnvironment('dart.library._ddc_only');
const bool isDart2JS = const bool.fromEnvironment('dart.tool.dart2js');
const bool isJS = isDart2JS || isDDC;
There was a problem hiding this comment.
Thank you for a very good advice, @srujzs . Updated.
|
Very good, thanks everybody! I'm landing this now. |
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacement of #3216, #3221, #3222 according to the discussion in #3222.