Skip to content

#3180. Simplify JSAnyOperation tests. #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 36 additions & 24 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t01.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,49 @@
/// The result of `this + any` in JavaScript.
///
/// @description Check that `add` returns result of `this + any` in JavaScript.
/// Test an empty JS object as `this`.
/// @author [email protected]

import 'dart:js_interop';
import 'dart:js_interop_unsafe';
import '../../../Utils/expect.dart';
import '../js_utils.dart';

main() {
testAdd(JSAny? underTest) {
eval(r'''
var object = {};
var one = object + 1; // String "[object Object]1"
var string = object + "s"; // String "[object Object]s"
var a1 = object + []; // String "[object Object]"
var a2 = object + [1, 2]; // String "[object Object]1,2"
var o1 = object + {}; // String "[object Object][object Object]"
var o2 = object + {"a": "b"}; // String "[object Object][object Object]"
var n = object + null; // String "[object Object]null"
var b1 = object + true; // String "[object Object]true"
var b2 = object + false; // String "[object Object]false"
var addNum = underTest + 2;
var addString = underTest + "text";
var addNull = underTest + null;
var addNaN = underTest + (0 / 0);
var addArray = underTest + [1, 2];
var addTrue = underTest + true;
''');

JSObject o = JSObject();
Expect.equals(globalContext["one"], o.add(1.toJS));
Expect.equals(globalContext["string"], o.add("s".toJS));
Expect.equals(globalContext["a1"], o.add([].jsify()));
Expect.equals(globalContext["a2"], o.add([1, 2].jsify()));
Expect.equals(globalContext["o1"], o.add(JSObject()));
Expect.equals(globalContext["o2"], o.add({"a": "b"}.jsify()));
Expect.equals(globalContext["n"], o.add(null.jsify()));
Expect.equals(globalContext["n"], o.add(null));
Expect.equals(globalContext["b1"], o.add(true.toJS));
Expect.equals(globalContext["b2"], o.add(false.toJS));
jsExpectEquals(globalContext["addNum"], underTest.add(2.toJS));
jsExpectEquals(globalContext["addString"], underTest.add("text".toJS));
jsExpectEquals(globalContext["addNull"], underTest.add(null));
jsExpectEquals(globalContext["addNaN"], underTest.add((0 / 0).toJS));
jsExpectEquals(globalContext["addArray"], underTest.add([1, 2].jsify()));
jsExpectEquals(globalContext["addTrue"], underTest.add(true.toJS));
}

main() {
eval("globalThis.underTest = 42;");
testAdd(42.toJS);

eval("globalThis.underTest = 'Some text';");
testAdd('Some text'.toJS);

eval("globalThis.underTest = null;");
testAdd(null);

eval("globalThis.underTest = 0 / 0;");
testAdd((0 / 0).jsify());

eval("globalThis.underTest = [];");
testAdd([].jsify());

eval("globalThis.underTest = false;");
testAdd(false.toJS);

eval("globalThis.underTest = {};");
testAdd(JSObject());
}
49 changes: 0 additions & 49 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t02.dart

This file was deleted.

42 changes: 0 additions & 42 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t03.dart

This file was deleted.

47 changes: 0 additions & 47 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t04.dart

This file was deleted.

46 changes: 0 additions & 46 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t05.dart

This file was deleted.

47 changes: 0 additions & 47 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t06.dart

This file was deleted.

42 changes: 0 additions & 42 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t07.dart

This file was deleted.

42 changes: 0 additions & 42 deletions LibTest/js_interop/JSAnyOperatorExtension/add_t08.dart

This file was deleted.

Loading