Skip to content

perf: remove composable meta property class #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jan 15, 2024

Use functions to create MetaProperty objects instead. Reduces mainly core module bundle size by 70 bytes.

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

📦 Bundle size (Angular v15)

Git ref: ed5ed79

Module file Size Base size Difference
ngx-meta-core.mjs 3427 bytes (3.4KiB) 3510 bytes (3.5KiB) -2.36%: -83 bytes (-83B)
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 902 bytes (902B) -.22%: -2 bytes (-2B)
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 691 bytes (691B) -.28%: -2 bytes (-2B)

Copy link

📦 Bundle size (Angular v17)

Git ref: ed5ed79

Module file Size Base size Difference
ngx-meta-core.mjs 3158 bytes (3.1KiB) 3230 bytes (3.2KiB) -2.22%: -72 bytes (-72B)
ngx-meta-json-ld.mjs 296 bytes (296B) 296 bytes (296B) No change
ngx-meta-open-graph-profile.mjs 286 bytes (286B) 286 bytes (286B) No change
ngx-meta-open-graph.mjs 734 bytes (734B) 736 bytes (736B) -.27%: -2 bytes (-2B)
ngx-meta-routing.mjs 1307 bytes (1.3KiB) 1307 bytes (1.3KiB) No change
ngx-meta-standard.mjs 1444 bytes (1.5KiB) 1444 bytes (1.5KiB) No change
ngx-meta-twitter-card.mjs 525 bytes (525B) 527 bytes (527B) -.37%: -2 bytes (-2B)

Copy link

📦 Bundle size (Angular v16)

Git ref: ed5ed79

Module file Size Base size Difference
ngx-meta-core.mjs 3423 bytes (3.4KiB) 3506 bytes (3.5KiB) -2.36%: -83 bytes (-83B)
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 902 bytes (902B) -.22%: -2 bytes (-2B)
ngx-meta-routing.mjs 1522 bytes (1.5KiB) 1522 bytes (1.5KiB) No change
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 691 bytes (691B) -.28%: -2 bytes (-2B)

@davidlj95 davidlj95 merged commit d6d9e58 into main Jan 15, 2024
@davidlj95 davidlj95 deleted the stacked/perf-remove-composable-meta-property-class branch January 15, 2024 14:57
Copy link

🎉 This PR is included in version 1.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidlj95 davidlj95 linked an issue Jan 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce bundle size
1 participant