Make py_class!'s generated type public #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 21, 2016 16:15
Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]>
struct DataIsDropped is public, so all of its fields needs to be public as well. Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]>
|
I investigated the failing testcase and it seems like Update: It was an FFI bug :) |
Use null-terminated strings to call PyErr_NewException() Signed-off-by: Tibor Benke <[email protected]>
|
I don't think extension types should be public by default. See #46. I've cherry-picked the PyErr_NewException bugfix; thanks! |
|
Ok, thanks! Could you cherry-pick the documentation related fixes as well? And another question: what do you think, when will cpython 0.6 be ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
py_class!publicExtractPyObjectwithFromPyObjectin the documentation