#51611 - Extended Blazor server and webassembly options to match web format.

[khamzakhamzakhamza]

#51611 - Extended Blazor server and webassembly options to match web format.

Extends options consumed by the Blazor.start() method in blazor.server.js and blazor.webassembly.js to match how they work in blazor.web.js and in the documentation.

Description

I followed the design proposed by @MackinnonBuck and implemented the suggested changes. I have tested changes locally and everything works as expected.

I couldn't find any unit or integration tests for the Boot classes and felt hesitant to create new ones. However, I am happy to do so if someone from the team decides they are needed.

[khamzakhamzakhamza]

@khamzakhamzakhamza please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

[MackinnonBuck]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[MackinnonBuck]

Sorry to revoke the approval, but we'll likely need tests to ensure that this doesn't break in the future. E2E tests are probably the easiest way to test this (rather than trying to test the Boot.*.ts code directly).

[MackinnonBuck]

Related to #56758. We'd only want to take one of these changes, as they do the same thing.

[dotnet-policy-service]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

[maraf]

@khamzakhamzakhamza Thank you for your contribution and sorry for a late reply.

We need some automated tests validating that options are correctly propagated. The easiest way to achieve it is through E2E test. There are tests that contains some startup options and we need to modify them to run once with wasm/server options as they do now and second with options matching web format. For WebAssembly such test candidate might be https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/E2ETest/Tests/WebAssemblyConfigureRuntimeTest.cs#L33 that is running https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/testassets/BasicTestApp/wwwroot/index.html#L66-L70. For Server we probably need to create a new test

[guardrex]

@maraf ... It looks like this won't make Preview 1. I have the docs PR (dotnet/AspNetCore.Docs #34660) ready to merge whenever this reaches a preview release.

[dotnet-policy-service]

Hi @khamzakhamzakhamza.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

[guardrex]

@maraf @javiercn ... DAH! 😄 ... I have the docs PR (dotnet/AspNetCore.Docs #34660) set up to react to this. I'm 🤞🍀 that this can make .NET 10 so that my work doesn't go to waste. It was a pain to set up due to the complex article versioning required.

[guardrex]

@lewing ... This closed again. Let me know if it's going to be dropped ... I'll close the docs PR if that happens.