Skip to content

using one style approach for all 3 configs WebAssembly, Web and Server #56758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vladimir-shirmanov
Copy link

@vladimir-shirmanov vladimir-shirmanov commented Jul 12, 2024

[Blazor] Accept the blazor.web.js startup options format in blazor.{server|webassembly}.js

Description

Added config properties to blazor.{server|webassembly}.js to follow the same structure as blazor.web.js

Fixes #51611

@vladimir-shirmanov vladimir-shirmanov requested a review from a team as a code owner July 12, 2024 10:17
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jul 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 12, 2024
@vladimir-shirmanov

This comment was marked as resolved.

@mkArtakMSFT
Copy link
Contributor

@javiercn can you please review this? Thanks!

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 20, 2024
Copy link

Commenter does not have sufficient privileges for PR 56758 in repo dotnet/aspnetcore

@vladimir-shirmanov
Copy link
Author

reopening

/azp run

@vladimir-shirmanov
Copy link
Author

Hi there, @javiercn @mkArtakMSFT, I don't have sufficient permissions to rerun the ci. What are the next steps for this PR?

@javiercn
Copy link
Member

@vladimir-shirmanov we need some E2E tests (either new ones, or modify existing ones) to make sure that things are working and we don't break this in the future.

@vladimir-shirmanov
Copy link
Author

@vladimir-shirmanov we need some E2E tests (either new ones, or modify existing ones) to make sure that things are working and we don't break this in the future.

Ok, let me think how to do that. Thanks

@MackinnonBuck
Copy link
Member

Related to #54649. We'd only want to take one of these changes, as they do the same thing.

@lewing lewing requested a review from maraf January 22, 2025 03:07
@lewing lewing assigned maraf and unassigned lewing Jan 22, 2025
@javiercn
Copy link
Member

We would need E2E tests to validate the behavior and make sure that it doesn't break in the future.

@javiercn javiercn added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Feb 12, 2025
@danmoseley danmoseley requested a review from Copilot February 14, 2025 04:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Components/Web.JS/src/Platform/WebAssemblyStartOptions.ts:41

  • [nitpick] The property name 'webAssembly' might be redundant since it has the same type as the interface itself. Consider renaming it to avoid redundancy.
webAssembly?: WebAssemblyStartOptions

Copy link
Contributor

Hi @vladimir-shirmanov.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@dotnet-policy-service dotnet-policy-service bot added the stale Indicates a stale issue. These issues will be closed automatically soon. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun pr: pending author input For automation. Specifically separate from Needs: Author Feedback stale Indicates a stale issue. These issues will be closed automatically soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blazor] Accept the blazor.web.js startup options format in blazor.{server|webassembly}.js
6 participants