-
Notifications
You must be signed in to change notification settings - Fork 10.4k
using one style approach for all 3 configs WebAssembly, Web and Server #56758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using one style approach for all 3 configs WebAssembly, Web and Server #56758
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@javiercn can you please review this? Thanks! |
Commenter does not have sufficient privileges for PR 56758 in repo dotnet/aspnetcore |
/azp run |
Hi there, @javiercn @mkArtakMSFT, I don't have sufficient permissions to rerun the ci. What are the next steps for this PR? |
@vladimir-shirmanov we need some E2E tests (either new ones, or modify existing ones) to make sure that things are working and we don't break this in the future. |
Ok, let me think how to do that. Thanks |
Related to #54649. We'd only want to take one of these changes, as they do the same thing. |
We would need E2E tests to validate the behavior and make sure that it doesn't break in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Components/Web.JS/src/Platform/WebAssemblyStartOptions.ts:41
- [nitpick] The property name 'webAssembly' might be redundant since it has the same type as the interface itself. Consider renaming it to avoid redundancy.
webAssembly?: WebAssemblyStartOptions
Hi @vladimir-shirmanov. |
[Blazor] Accept the blazor.web.js startup options format in blazor.{server|webassembly}.js
Description
Added config properties to blazor.{server|webassembly}.js to follow the same structure as blazor.web.js
Fixes #51611