-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for *-version
attributes in the docs
#737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As per brief chat this morning, I think there's a looming need for guidance if folks start using those attributes a lot. Seems like it was well understood, but for tracking purposes I'm dropping thoughts here too.
Either way, it seems like it means if 9.1 and 9.0 continue to coexist and get releases for quite a while, that it might be a pain for folks to likewise maintain all the docset- or page-level |
This functionality would also be helpful for release dates in the release notes. I suspect it might get tricky to maintain these across repos (we already have to open PRs across all repos using Stack versioning because the 9.0 release date changed....). |
To @lcawl's point, we are versionless in v9 with minor and patch content labeled with applies_to. This means we will have to support multiple minors in examples and other version specific things (ie, it depends on what minor you are on or interested in) and the implication is that just the latest stack version isn't enough. In the curl example above: That said, we should definitely have the variables above for the static use cases. |
Fixes various syntax and rendering errors that might include: * Fixing broken images * Hardcoding book-level substitution values * Fixing incorrectly closed blocks (admonitions, tab sets, code blocks, dropdowns etc.) * Fixing poorly migrated complex tables * Fixing poorly migrated lists * Fixing poorly migrated tab sets * Removing inline text formatting from directive titles where they won't be rendered (for example, inline `code` formatting in dropdown titles) * Specifying if a version is trying to communicate if a feature was added, deprecated, or coming (for example, during migration `deprecated:[8.15.0]` became `[8.15.0]`, which doesn't give any information about _what_ happened in 8.15.0) * Fixing nested dropdowns / definition lists * Fixing poorly migrated footnotes * Updating references to prerelease `9.0.0` versions (using a repo-level substitution until there is a solution to elastic/docs-builder#737)
Here's a concrete example of where we might need to use version variables (now that 9.0.1 has been released): elastic/docs-content#1373. |
I also had some comments in elastic/elasticsearch-hadoop#2378 where I think we'll need to have more context-specificity (e.g. "stack-current-version" and "stack-next-version" variables (or even more specific "stack-90-version" and "stack-91-version" for situations where both will co-exist on a branch) |
Summary
We need a way to globally add product versions to the docs. The product versions are primarily used in code blocks for installation instructions. Using a variable in these instructions allows us to easily update code commands as we release product updates.
This tasks requires:
Products identified as needing version variables:
{{context.stack_version}}
{{context.eck_version}}
{{context.ece_version}}
{{context.apm-android_version}}
{{context.apm-go_version}}
{{context.apm-os_version}}
{{context.apm-java_version}}
{{context.apm-dotnet_version}}
{{context.apm-nodejs_version}}
{{context.apm-php_version}}
{{context.apm-python_version}}
{{context.apm-ruby_version}}
{{context.apm-rum_version}}
Release date variables
{{context.90_release_date}}
Questions from writers:
docset.yml
variables in the meantime? The downside of this approach is that we will need to updatedocset.yml
files in at least 30 repositories when 9.0 releases, and then again for every subsequent release.Helpful regex
This may help you find
version
attributes that need to be updated:\{\{([^}]*version[^}]*)\}\}
The text was updated successfully, but these errors were encountered: