Update stack-version to 9.0.1
#1373
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
commented
May 6, 2025
| @@ -191,7 +191,7 @@ This approach should be used only temporarily as a last resort to restore functi | |||
|
|
|||
| ## Limitations [alerting-limitations] | |||
|
|
|||
| The following limitations and known problems apply to the {{version}} release of the {{kib}} {{alert-features}}: | |||
| The following limitations and known problems apply to the {{stack-version}} release of the {{kib}} {{alert-features}}: | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -9,7 +9,7 @@ mapped_pages: | |||
|
|
|||
| # Limitations [ml-limitations] | |||
|
|
|||
| The following limitations and known problems apply to the {{version}} release of the Elastic {{ml-features}}. The limitations are grouped into four categories: | |||
| The following limitations and known problems apply to the {{stack-version}} release of the Elastic {{ml-features}}. The limitations are grouped into four categories: | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -9,7 +9,7 @@ mapped_pages: | |||
|
|
|||
| # Limitations [ml-dfa-limitations] | |||
|
|
|||
| The following limitations and known problems apply to the {{version}} release of the Elastic {{dfanalytics}} feature. The limitations are grouped into the following categories: | |||
| The following limitations and known problems apply to the {{stack-version}} release of the Elastic {{dfanalytics}} feature. The limitations are grouped into the following categories: | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -8,7 +8,7 @@ mapped_pages: | |||
|
|
|||
| # Limitations [ml-nlp-limitations] | |||
|
|
|||
| The following limitations and known problems apply to the {{version}} release of the Elastic {{nlp}} trained models feature. | |||
| The following limitations and known problems apply to the {{stack-version}} release of the Elastic {{nlp}} trained models feature. | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -53,7 +53,7 @@ The driver version cannot be newer than the {{es}} version. For example, {{es}} | |||
|
|
|||
| ## Download the `.msi` package(s) [download] | |||
|
|
|||
| Download the `.msi` package for Elasticsearch SQL ODBC Driver {{version}} from: [https://www.elastic.co/downloads/odbc-client](https://www.elastic.co/downloads/odbc-client) | |||
| Download the `.msi` package for Elasticsearch SQL ODBC Driver {{stack-version}} from: [https://www.elastic.co/downloads/odbc-client](https://www.elastic.co/downloads/odbc-client) | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -9,7 +9,7 @@ mapped_pages: | |||
|
|
|||
| # Limitations [transform-limitations] | |||
|
|
|||
| The following limitations and known problems apply to the {{version}} release of the Elastic {{transform}} feature. The limitations are grouped into the following categories: | |||
| The following limitations and known problems apply to the {{stack-version}} release of the Elastic {{transform}} feature. The limitations are grouped into the following categories: | |||
There was a problem hiding this comment.
Should we even be using a version variable here?
| @@ -135,7 +135,7 @@ output.kafka: | |||
| message: "ERR" | |||
| ``` | |||
|
|
|||
| This configuration results in topics named _critical-{{version}}_, _error-{{version}}_, and _logs-{{version}}_. | |||
| This configuration results in topics named _critical-{{stack-version}}_, _error-{{stack-version}}_, and _logs-{{stack-version}}_. | |||
There was a problem hiding this comment.
Should this actually not use version variables (is the version the agent.version)?
Suggested change
| This configuration results in topics named _critical-{{stack-version}}_, _error-{{stack-version}}_, and _logs-{{stack-version}}_. | |
| This configuration results in topics named `critical-{VERSION}`, `error-{VERSION}`, and `logs-{VERSION}`. |
| @@ -218,7 +218,7 @@ The `proxy_use_local_resolver` option determines if {{ls}} hostnames are resolve | |||
|
|
|||
| #### `index` [apm-logstash-index] | |||
|
|
|||
| The index root name to write events to. The default is `apm-server`. For example `"apm"` generates `"[apm-]VERSION-YYYY.MM.DD"` indices (for example, _"apm-{{version}}-2017.04.26"_). | |||
| The index root name to write events to. The default is `apm-server`. For example `"apm"` generates `"[apm-]VERSION-YYYY.MM.DD"` indices (for example, _"apm-{{stack-version}}-2017.04.26"_). | |||
There was a problem hiding this comment.
Since this is just an example we probably don't have to use a version variable, but in my opinion it doesn't hurt.
| @@ -15,7 +15,7 @@ applies_to: | |||
|
|
|||
| ## Upgrade the {{stack}} [apm-integration-upgrade-ess-1] | |||
|
|
|||
| Use the {{ecloud}} Console to upgrade the {{stack}} to version {{version}}. See the [Upgrade guide](/deploy-manage/upgrade/deployment-or-cluster.md) for details. | |||
| Use the {{ecloud}} Console to upgrade the {{stack}} to version {{stack-version}}. See the [Upgrade guide](/deploy-manage/upgrade/deployment-or-cluster.md) for details. | |||
There was a problem hiding this comment.
Should this even use a version variable?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution until we have a solution for elastic/docs-builder#737. I used the substitution key
stack-versionso we can easily search and replace across repos until there's a permanent, centralized solution.