-
Notifications
You must be signed in to change notification settings - Fork 987
[docs] Fix various syntax and rendering errors #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[docs] Fix various syntax and rendering errors #2378
Conversation
<dependency> | ||
<groupId>org.elasticsearch</groupId> | ||
<artifactId>elasticsearch-hadoop</artifactId> | ||
<version>9.0.0-beta1</version> | ||
<version>{{version}}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>{{version}}</version> | |
<version>{{version-90}}</version> |
@@ -6,6 +6,7 @@ toc: | |||
- toc: reference | |||
- toc: release-notes | |||
subs: | |||
version: "9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we will likely need to be more specific, per discussions in elastic/docs-builder#737
version: "9.0.0" | |
version-90: "9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intended to be a temporary solution until elastic/docs-builder#737 is addressed and there's a central place to manage versions.
I had to add version
subs to multiple repos in related PRs. I'm not planning to go back and update all other repos unless elastic/docs-builder#737 can't be addressed before the next release, but you're welcome to make this change in this repo (and any other repos) if you think that would be better.
<dependency> | ||
<groupId>org.elasticsearch</groupId> | ||
<artifactId>elasticsearch-hadoop-mr</artifactId> <1> | ||
<version>9.0.0-beta1</version> | ||
<version>{{version}}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>{{version}}</version> | |
<version>{{version-90}}</version> |
<dependency> | ||
<groupId>org.elasticsearch</groupId> | ||
<artifactId>elasticsearch-hadoop-hive</artifactId> <1> | ||
<version>9.0.0-beta1</version> | ||
<version>{{version}}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>{{version}}</version> | |
<version>{{version-90}}</version> |
<dependency> | ||
<groupId>org.elasticsearch</groupId> | ||
<artifactId>elasticsearch-spark-30_2.12</artifactId> <1> | ||
<version>9.0.0-beta1</version> | ||
<version>{{version}}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<version>{{version}}</version> | |
<version>{{version-90}}</version> |
Fixes various syntax and rendering errors that might include:
code
formatting in dropdown titles)deprecated:[8.15.0]
became[8.15.0]
, which doesn't give any information about what happened in 8.15.0)9.0.0
versions (using a repo-level substitution until there is a solution to Add support for*-version
attributes in the docs docs-builder#737)Links to pages that were updated: