Skip to content

fix: handlebars [email protected] #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi MichalBryxi commented Apr 17, 2025

require() of ES Module /Users/michal/ember/ember-intl/node_modules/.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.

- Without this the CI fails, because it installs incorrect dependencies
@@ -41,7 +41,7 @@ jobs:
cache: pnpm
- name: Install Dependencies
if: env.SHORT_CIRCUIT == 'false'
run: pnpm install --no-lockfile
run: pnpm install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always a good idea.

@MichalBryxi
Copy link
Contributor Author

Despite GitHub insisting that there is some diff, I see no diff from this branch against main so I would just close this.

@MichalBryxi MichalBryxi closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with @handlebars/parser @ 2.2.0
1 participant