Skip to content

fix: handlebars [email protected] #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: handlebars [email protected] #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0dba5c
fix: By bumping node version to v20.19 we will fix the @handlebars/pa…
MichalBryxi Apr 15, 2025
75dbee4
fix: Do use lockfile!
MichalBryxi Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/addon-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
# Fetch tags pointing to the current commit
TAGS=$(git tag --points-at $GITHUB_SHA)
echo "Tags found: $TAGS"

# Check if a tag exists and if the ref is 'refs/heads/main' or 'refs/heads/master'
if [ -n "$TAGS" ] && ([[ "${GITHUB_REF}" == "refs/heads/main" ]] || [[ "${GITHUB_REF}" == "refs/heads/master" ]]); then
echo "SHORT_CIRCUIT=true" >> $GITHUB_ENV
Expand All @@ -41,7 +41,7 @@ jobs:
cache: pnpm
- name: Install Dependencies
if: env.SHORT_CIRCUIT == 'false'
run: pnpm install --no-lockfile
run: pnpm install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always a good idea.

- name: Deploy Docs
if: env.SHORT_CIRCUIT == 'false'
run: pnpm ember deploy production
run: pnpm ember deploy production
10 changes: 5 additions & 5 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.19.x
- uses: pnpm/action-setup@v4
with:
version: 9
Expand All @@ -46,12 +46,12 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.19.x
- uses: pnpm/action-setup@v4
with:
version: 9
- name: Install dependencies
run: pnpm i --no-lockfile
run: pnpm i
- name: Test
run: pnpm test:${{ matrix.script-name }}

Expand All @@ -71,7 +71,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.19.x
- uses: pnpm/action-setup@v4
with:
version: 9
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.19.x
- uses: pnpm/action-setup@v4
with:
version: 9
Expand Down
4 changes: 2 additions & 2 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 18.20.3
pnpm 9.9.0
nodejs 20.19
pnpm 9.9.0
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@glimmer/component": "^1.1.2",
"@glimmer/syntax": "^0.87.1",
"@glimmer/tracking": "^1.1.2",
"@handlebars/parser": "^2.1.0",
"@handlebars/parser": "^2.2.0",
"broccoli-bridge": "^1.0.0",
"broccoli-caching-writer": "^3.0.3",
"broccoli-filter": "^1.3.0",
Expand Down
Loading