Skip to content

Code Quality: Introduced IStorageTrashBinService #15773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 7, 2024

Resolved / Related Issues

Steps used to test these changes

  1. Open Files
  2. Go to the Recycle Bin
  3. Empty the bin or Restore the bin
  4. Move a file to the bin

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch from fe89937 to 5fac69c Compare July 9, 2024 22:40
@yaira2 yaira2 force-pushed the main branch 3 times, most recently from 2e4f94d to 98eb6b4 Compare July 22, 2024 15:55
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch 2 times, most recently from bfbd8d4 to 6433bf9 Compare July 23, 2024 08:50
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch from 1f2229f to a323308 Compare July 31, 2024 01:45
@0x5bfa 0x5bfa marked this pull request as ready for review August 20, 2024 15:46
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch 2 times, most recently from d233e3b to fde1e7e Compare August 20, 2024 15:55
@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 20, 2024

Ready.

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch from 5c4ad52 to e7b8c44 Compare August 21, 2024 15:09
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-VanaraRemoval2 branch from f7e5871 to 77a5b8a Compare August 24, 2024 09:35
@0x5bfa 0x5bfa requested a review from yaira2 August 24, 2024 09:35
@0x5bfa 0x5bfa changed the title Code Quality: Introduced IWindowsRecycleBinService Code Quality: Introduced IStorageTrashBinService Aug 28, 2024
@yaira2 yaira2 merged commit 8d3f902 into files-community:main Sep 1, 2024
6 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 1, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-VanaraRemoval2 branch September 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs - code review ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants