runtime: make BPF Loader v3 structs zero-alloc #5079
+155
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
force-pushed
the
ripatel/loader-v3-noalloc
branch
from
62ec884 to
41021bb
Compare
- Add helper for converting between pointer and flat option representation - Add decode_flat helper
Removes dynamic allocations in BPF Loader v3 by turning pointer option types into flat option types.
ripatel-fd
force-pushed
the
ripatel/loader-v3-noalloc
branch
from
41021bb to
8750751
Compare
| if( ptr ) (target . name) = *ptr; \ | ||
| } | ||
|
|
||
| /* fd_types_option_flat_to_nullable creates a nullable pointer to a flat |
There was a problem hiding this comment.
Suggested change
| /* fd_types_option_flat_to_nullable creates a nullable pointer to a flat | |
| /* fd_types_option_flat_to_nullable creates a nullable pointer from a flat |
| } | ||
| } | ||
| }; | ||
| fd_types_option_flat_from_nullable( |
There was a problem hiding this comment.
fd_types_option_flat_from_nullable ends up getting repeated everywhere we set up a bpf loader state struct. I'd prefer using a setup / init function for fd_bpf_upfradeable_loader_state_t to reduce the repetition.
There was a problem hiding this comment.
@cali-jumptrading Good point. We could also have a macro that expands to initializer syntax like this:
my_struct_t s = {
.inner = {
fd_types_option_flat_init_from_nullable( option_name, pointer ),
.bla = x,
}
};
The macro name is disgusting. If you have better ideas, please shout!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types: add APIs for zero alloc decoding
representation
runtime: make BPF Loader v3 structs zero-alloc
Removes dynamic allocations in BPF Loader v3 by turning pointer
option types into flat option types.