Skip to content

🔧 chore(aci): add workflow_id to sentry app action #89351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

iamrajjoshi
Copy link
Member

i missed using workflow_id in the sentry app payload when the noa is invoked

@iamrajjoshi iamrajjoshi self-assigned this Apr 10, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners April 10, 2025 21:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/sentry_apps/tasks/sentry_apps.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #89351       +/-   ##
===========================================
+ Coverage   72.23%   87.70%   +15.47%     
===========================================
  Files       10139    10148        +9     
  Lines      573116   573336      +220     
  Branches    22514    22514               
===========================================
+ Hits       413983   502848    +88865     
+ Misses     158690    70045    -88645     
  Partials      443      443               

@iamrajjoshi iamrajjoshi merged commit aa857a9 into master Apr 14, 2025
60 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/aci/add-workflow-id-sentry-app-action branch April 14, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants