Skip to content

🔧 chore(aci): add workflow_id to sentry app action #89351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

🔧 chore(aci): add workflow_id to sentry app action #89351

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6526f85
:wrench: chore: add workflow_id to sentrya pp action
iamrajjoshi Apr 10, 2025
92c72db
:wrench: chore: remove is none check
iamrajjoshi Apr 10, 2025
6c0d085
:wrench: chore: fix typo
iamrajjoshi Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sentry/sentry_apps/tasks/sentry_apps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from sentry.models.organization import Organization
from sentry.models.organizationmapping import OrganizationMapping
from sentry.models.project import Project
from sentry.notifications.notifications.rules import get_key_from_rule_data
from sentry.sentry_apps.api.serializers.app_platform_event import AppPlatformEvent
from sentry.sentry_apps.metrics import (
SentryAppEventType,
Expand Down Expand Up @@ -529,8 +530,9 @@ def notify_sentry_app(event: GroupEvent, futures: Sequence[RuleFuture]):
id = f.rule.id
# if we are using the new workflow engine, we need to use the legacy rule id
if features.has("organizations:workflow-engine-trigger-actions", event.group.organization):
id = f.rule.data.get("actions", [{}])[0].get("legacy_rule_id")
assert id is not None
id = get_key_from_rule_data(f.rule, "legacy_rule_id")
elif features.has("organizations:workflow-engine-ui-links", event.group.organization):
id = get_key_from_rule_data(f.rule, "workflow_id")

settings = f.kwargs.get("schema_defined_settings")
if settings:
Expand Down
Loading