-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Flat fix #3114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Flat fix #3114
Conversation
…er.cpp into bindings_flat
In CI Ruby don't like my -DBINDINGS_FLAT (which also creates a GGML_BINDINGS_FLAT) The whole point of the switch is that it makes the additions / changes transparent to other systems |
@peardox Hi, I sent a pull request to fix Ruby problem to your branch: WhisperBooks#1 |
Fix for Ruby options Thanks - I'm clueless regartding Ruby...
Removed superfluous line in ggml-backend.h |
@danbev Made changes - can you stick it thru CI just to check pls |
Arggh - ruby failed again |
Seems a backup file ( |
Dunno where that came from :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the goal of this change?
Note that this is not suitable to merge - it's probably better to keep in a separate fork.
First it should be mentioned that WHISPER_BINDINGS_FLAT is specifically designed to only do anything if passed to the build command. The main purpose is to make -DBUILD_SHARED_LIBS=ON -DGGML_BACKEND_DL=ON -DGGML_CPU_ALL_VARIANTS=ON work If devices are loaded via e.g. whisper_flat_backend_load_all() or ggml_backend_try_load_best("cpu", nullptr) before the model is loaded this situation is resolved and examples all work. The rest of the stuff is for non C++ language support. |
Fixingcommit conflicts