Skip to content

Impl Display for built-ins #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Impl Display for built-ins #224

merged 1 commit into from
Apr 13, 2023

Conversation

hapenia
Copy link
Contributor

@hapenia hapenia commented Apr 12, 2023

related to #110

@Bromeon Bromeon mentioned this pull request Apr 12, 2023
Closed
Bromeon
Bromeon reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙂
Minor formatting comments.

bors try

bors bot added a commit that referenced this pull request Apr 12, 2023
@bors
Try #224:
1817a79
@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Apr 12, 2023
@hapenia hapenia marked this pull request as draft April 12, 2023 08:35
hapenia
hapenia commented Apr 12, 2023
View reviewed changes
@hapenia hapenia marked this pull request as ready for review April 12, 2023 08:42
Bromeon
Bromeon reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the Contribution guidelines regarding number of commits.

godot-core/src/builtin/aabb.rs
Comment on lines +88 to +89
/// Example:
/// ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You applied the changes only here, not in all the other cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I will fix it :)

@hapenia hapenia force-pushed the feature/impl-display-for-built-ins branch from c8a3eb5 to 949537f Compare April 12, 2023 10:08
@Bromeon
Copy link
Member

Bromeon commented Apr 12, 2023

There are small merge conflicts after merging #204, would you be able to address them?
Sorry for the inconvenience, that bugfix really had highest priority! 😕

@hapenia hapenia force-pushed the feature/impl-display-for-built-ins branch from 949537f to fc8e6bb Compare April 13, 2023 01:52
@hapenia
Copy link
Contributor Author

hapenia commented Apr 13, 2023

@Bromeon Fixed.

Bromeon
Bromeon approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 13, 2023

Build succeeded:

  • full-ci

@bors bors bot merged commit d63c0a9 into godot-rust:master Apr 13, 2023
@bors

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

Assignees
No one assigned
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hapenia @Bromeon