Remove "dummy" renderer from the editor dropdown. #105216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Code looks good to me.
However, should we also prevent this rendering method from being selected in the Project Settings? If you don't have a screen reader, switching to it then restarting the project will make the editor unusable until you manually edit project.godot while the editor is closed.
Yes, probably. It was added as fallback in case you are using engine with screen-reader and no functional GPU, not as a selectable option. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes minor UI regression from #76829 (“dummy” rendering driver showing in the editor dropdown).