Move and simplify Object's connect description slightly
#94143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
documentation-object-connect-to-signal-too-long-didn't-read
branch
from
7ab1eeb to
d45a602
Compare
Mickeon
added
cherrypick:4.2
Mickeon
force-pushed
the
documentation-object-connect-to-signal-too-long-didn't-read
branch
from
d45a602 to
824d4ee
Compare
Calinou
reviewed
Jul 13, 2024
akien-mga
removed
the
cherrypick:4.2
Calinou
approved these changes
Apr 9, 2025
Mickeon
added
cherrypick:4.4
|
Thanks! |
Mickeon
deleted the
documentation-object-connect-to-signal-too-long-didn't-read
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94122 (although there should be a scroll-bar really, just in case)
This PR moves the extremely, utterly excessively long description of Object
connectto Signal's leading description, and attempts to simplify it slightly. It also rewords things aroundconnectfor more consistency.This part of the docs has always been a pain to figure out. I don't know why someone thought it was a good idea to have it here. Now we're left with a lot of verbose info that I am not sure has ever been necessary, nor fitting for a method description.