This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Don't pass an owned string to g_quark_from_static_string() #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When called more than once or for a quark that already exists otherwise, we would always leak the string. Instead pass an unowned string to g_quark_from_string().
|
@GuillaumeGomez This should also be part of the bugfix release made for #589. While leaks are safe, they're still annoying and not good :) |
|
👍 |
|
We can add the "from_static_string" implementation by asking a |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called more than once or for a quark that already exists otherwise,
we would always leak the string. Instead pass an unowned string to
g_quark_from_string().
CC @GuillaumeGomez @EPashkin