Skip to content

Sets enable_stabilization to false by default. #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions source/isaaclab/isaaclab/sim/simulation_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,14 @@ class PhysxCfg:
"""Enable a second broad-phase pass that makes it possible to prevent objects from tunneling through each other.
Default is False."""

enable_stabilization: bool = True
"""Enable/disable additional stabilization pass in solver. Default is True."""
enable_stabilization: bool = False
"""Enable/disable additional stabilization pass in solver. Default is False.

.. note::

Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we throw a warning about this finding from the code? This way users know that if they see some issues in forces, they have a heads up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz).
We recommend setting this flag to true only when the simulation step size is large (i.e., less than 30 Hz or more than 0.0333 seconds).

Enabling this flag can lead to incorrect forces being read from the contact sensor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a warning. Also a bit confusing: are forces just computed incorrectly or they are reported wrong?

Suggested change
Enabling this flag can lead to incorrect forces being read from the contact sensor.
.. warn::
Enabling this flag may lead to incorrect contact forces report from the contact sensor.

"""

enable_enhanced_determinism: bool = False
"""Enable/disable improved determinism at the expense of performance. Defaults to False.
Expand Down