Update changelog for v3 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 78.08% 77.35% -0.74%
==========================================
Files 15 16 +1
Lines 1734 1753 +19
==========================================
+ Hits 1354 1356 +2
- Misses 380 397 +17
Continue to review full report at Codecov.
|
jonhoo
approved these changes
May 13, 2021
|
|
||
| ### Changed | ||
| - MSRV increased to 1.43 for nom6 and bitvec | ||
| - `expunge` and `uid_expunge` return `Result<Deleted>` instead of `Result<Vec<u32>>`. | ||
|
|
||
| ### Removed | ||
| - Idle `wait_keepalive_while` replaces `wait_keepalive` and takes a callback with an `UnsolicitedResponse` in parameter. |
There was a problem hiding this comment.
@mordak I feel like we can be a bit more elaborate here — want to give a stab at updating this in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added breaking changes I noticed while integrating the
v3.0.0-alpha.3in my tool: pimalaya/himalaya@36d3cd6. I also replaced thev3.0.0 - ???withUnreleased, let me know if it's okey.This change is