Add MacOS Arm64 support (Take 2) #132
Merged
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
looking forward to this :) |
bording
approved these changes
Nov 4, 2021
|
@drasticactions Thanks for the PR! I'll push up a new package with this change after I get #133 in. |
|
2.0.315-alpha.0.7 has been pushed to nuget.org. |
|
With this windows x64 does not work for me anymore |
@hendrikmennen I'm not really sure how you were trying it without an updated LibGit2Sharp package that uses it also being available. You can't just mix and match package versions. I just pushed LibGit2Sharp 0.27.0-preview-0156 to nuget.org, so give that a try. |
|
Thanks I tried. On my MacBook Air (M1) the OSX64 version works, Arm64 sadly not |
Can you be more specific? What error messages are you getting? What kind of project is it? What sort of TFMs? |
|
When I compile with -r osx-arm64 this happens. |
|
What TFM is the project targeting? |
|
net6.0 |
|
Okay, we need to see more info about what is failing for the library load. Set If it doesn't seem to work, you may need to disable SIP temporarily. |
|
Like that? |
|
Ok, next thing, can you show the the contents of the bin folders when you build with both |
|
I uploaded a zip from both versions to https://cdn.vhdplus.com/vhdpluside/0.10.5.0/ |
|
UPDATE: I realized there was a problem with the I've pushed up LibGit2Sharp 0.27.0-preview-0158 that includes the new binary, so hopefully that fixes things! Oh, one last thing, can you run |
|
Yes it works! uname-m gives me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edits the scripts and yaml to include a
osx-arm64target. This should add the correct dylib to the Nuget package to be consumed by the main libgit2 library.Fixes #129
This also adds the review fixes from the previous PR. This does use Big Sur for compiling, since that's the only way to get the arm64 build.