Skip to content

Build native libs for linux-musl-arm and linux-musl-arm64 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

arturcic
Copy link
Contributor

@arturcic arturcic commented Nov 1, 2021

See #130 for initial PR.

I commented on the changes on the original PR. I think we need to continue the discussion here.
This PR is made from a branch instead of master

@bording
Copy link
Member

bording commented Nov 4, 2021

I did also merge #132 which has introduced a conflict here, sorry about that!

@arturcic
Copy link
Contributor Author

arturcic commented Nov 4, 2021

I did also merge #132 which has introduced a conflict here, sorry about that!

I'm glad that that one was merged. I'll rebase my changes and will work on changes you requested

@arturcic arturcic force-pushed the feature/arm-alpine branch 4 times, most recently from 8f20259 to 97df2c9 Compare November 4, 2021 08:46
@arturcic
Copy link
Contributor Author

arturcic commented Nov 4, 2021

@bording rebased and fixed according change requests.

@bording bording merged commit 18bf999 into libgit2:master Nov 4, 2021
@arturcic arturcic deleted the feature/arm-alpine branch November 4, 2021 14:49
@arturcic
Copy link
Contributor Author

arturcic commented Nov 4, 2021

@bording thank you for merging this one. Do you have any plans to release a new version of the package?

@bording
Copy link
Member

bording commented Nov 4, 2021

@bording thank you for merging this one. Do you have any plans to release a new version of the package?

Yep, just waiting for the linux-musl builds to finish, they are so slow!

@arturcic
Copy link
Contributor Author

arturcic commented Nov 4, 2021

Agree, one of the reasons I wanted to run in parallel. Any plans also to release a LibGit.Sharp new version to reference the new native package?

@bording
Copy link
Member

bording commented Nov 4, 2021

Agree, one of the reasons I wanted to run in parallel.

I looked at the build times between CI runs with and without the parallel setting, and it wasn't a clear win. Some things got a little bit faster, but the only things that really matter are the musl-arm builds.

The linux-musl-arm64 build does see some big improvements with the parallel setting, but the linux-musl-arm build appears to get slower with the setting, removing any gains and making the total build time about the same.

Any plans also to release a LibGit.Sharp new version to reference the new native package?

I won't be able to get to that today, so if you wanted to open a PR that included an update to the new native binaries package and introduced some additional linux distros into the testing matrix, that would be appreciated.

@arturcic
Copy link
Contributor Author

arturcic commented Nov 4, 2021

I won't be able to get to that today, so if you wanted to open a PR that included an update to the new native binaries package and introduced some additional linux distros into the testing matrix, that would be appreciated.

I will have a look

@bording
Copy link
Member

bording commented Nov 4, 2021

2.0.315-alpha.0.7 has been pushed to nuget.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants