[WIP] Add MSM8974 #35
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Weiss <[email protected]>
lumag
reviewed
Jun 18, 2025
| .enable_mask = BIT(0), // FIXME | ||
|
|
||
| .mux_reg = 0x62024, // FIXME | ||
| .mux_mask = 0x3ff, // FIXME |
There was a problem hiding this comment.
I think this should be:
.enable_reg = 0x1880,
.enable_mask = BIT(16),
.mux_reg = 0x1880,
.mux_mask = 0xff,Hope this helps.
I'm not sure about the div_reg / etc, maybe they should be disabled.
There was a problem hiding this comment.
0x1ff (bits [8:0]) for mux_mask
div_reg is also 0x1880
div_mask is 0xf000 (bits [15:12])
div_val i don't know, you'll figure it out at runtime
| }, | ||
|
|
||
| .xo_div4_reg = 0x62008, | ||
| .debug_ctl_reg = 0x62048, |
|
|
||
| .xo_div4_reg = 0x62008, | ||
| .debug_ctl_reg = 0x62048, | ||
| .debug_status_reg = 0x6204c, |
| .div_val = 2, // FIXME | ||
| }, | ||
|
|
||
| .xo_div4_reg = 0x62008, |
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
please switch to an SPDX header instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need some help figuring out the remaining values marked with FIXME. I think I understand too little about debugcc and these old clock drivers :)
Downstream: https://github.com/FairphoneMirrors/android_kernel_fairphone_msm8974/blob/int/10/fp2/arch/arm/mach-msm/clock-8974.c#L4431