feat: NeverNone to always generate an optional field, and AlwaysNone #677
+72
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveitaly
changed the title
iloveitaly
force-pushed
the
never-none
branch
2 times, most recently
from
a86e363 to
4d86cc1
Compare
|
@adhtruong fixed up tests for this! Take a look when you can. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/677 |
adhtruong
reviewed
Apr 18, 2025
| """A factory field that marks as always generated, even if it's an optional.""" | ||
|
|
||
|
|
||
| class AlwaysNone: |
There was a problem hiding this comment.
Is this required? Does
from dataclasses import dataclass
from polyfactory.factories.dataclass_factory import DataclassFactory
@dataclass
class A:
a: int | None
class Factory(DataclassFactory[A]):
a = None
print(Factory.batch(size=10))work for this use case? Could this be documented
| # within get_field_value. | ||
| excluded_field_value = has_field_value and isinstance(field_value, (NeverNone, AlwaysNone)) | ||
|
|
||
| # TODO why do we need the BaseFactory check here, only dunder methods which are ignored would trigger this? # noqa: FIX002 |
There was a problem hiding this comment.
Suggested change
| # TODO why do we need the BaseFactory check here, only dunder methods which are ignored would trigger this? # noqa: FIX002 | |
| # Avoid considering fields on base field in case of clash |
or if fine to remove check then can do that
| @@ -334,6 +334,7 @@ def _handle_factory_field( # noqa: PLR0911 | |||
| if isinstance(field_value, Fixture): | |||
| return field_value.to_value() | |||
|
|
|||
| # if a raw lambda is passed, invoke it | |||
There was a problem hiding this comment.
nit: this applies to all callables rather than just lambdas. Can this be updated?
|
Just a friendly reminder about this pull request! Please let me know if there's anything else needed here. |
|
This would also be useful to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, there is not an ergonomic way to mark a single field as "required" in the sense
that polyfactory should always generate a value for it, even if it's marked as optional.
Curious what you think about the approach, I still need to:
Closes
#655